BZ#1486224 - Refactor sui group switching to use api #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllenBW
changed the title
|
@AllenBW this ready to go? |
|
@chriskacerguis Nope, still gotta do work, above mentioned pr was just merged in |
AllenBW
force-pushed
the
bug/1002-set-current-group-via-api
branch
3 times, most recently
from
2b4789b
to
b78f53a
Compare
AllenBW
commented
Sep 28, 2017
| $http.defaults.headers.common['X-Miq-Group'] = unescape(encodeURIComponent(group)) | ||
| $sessionStorage.miqGroup = group || null | ||
| $sessionStorage.selectedMiqGroup = group | ||
| if (typeof group === 'object') { |
There was a problem hiding this comment.
i know this is ugly,
why not just do
foo = group.stuff || group???
I WANT TO but our tests that rely on this work fail when this is written shorthand, i think it has something to do with running in strict mode 🤔
AllenBW
commented
Sep 28, 2017
| @@ -45,7 +45,7 @@ | |||
| padding-top: 19px | |||
|
|
|||
| .dropdown-menu | |||
| margin-top: 7px; | |||
| margin-top: 7px | |||
There was a problem hiding this comment.
exceeds the scope of this pr, buttttt it was broken :-/
AllenBW
force-pushed
the
bug/1002-set-current-group-via-api
branch
3 times, most recently
from
80802d2
to
61077f8
Compare
Rather than page reload, state reload sufficient
AllenBW
force-pushed
the
bug/1002-set-current-group-via-api
branch
from
61077f8
to
7b16290
Compare
|
Updated da message |
|
Checked commits AllenBW/manageiq-ui-service@7b16290~...654f16e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
AllenBW
changed the title
chriskacerguis
approved these changes
Sep 29, 2017
|
@chriskacerguis can you set the Milestone to Sprint 70 |
chriskacerguis
modified the milestones:
Sprint 71 Ending Oct 16, 2017,
Sprint 70 Ending Oct 2, 2017
|
@JPrause done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1486224
Right now it uses headers, taks a LOOOONNNGG time to take effect, most of the time feels broken, gonna switch this over to using api.
In order to keep excessive api calls down, require this work to be completed first
groupsmanageiq-api#74So what did we do?
mad props out to @jntullo for helpin' this reality come to 💡