Added ability for login screen to clear password on failed attempt #1142
Conversation
| .catch((response) => { | ||
| if (response.status === 401) { | ||
| vm.credentials.password = '' | ||
| Notifications.message('danger', '', __('Incorrect username or password.'), false) |
There was a problem hiding this comment.
If the response has a server message we should probably display that here
There was a problem hiding this comment.
We probably could but a couple of thoughts. The message that comes back just says "Authentication failed". At a minimum the message we display is a little more specific and it is also translated vs the raw message from the server. Keep in mind, I didn't add this notification message, merely moved it from the factory up to the state that it pertains to.
There was a problem hiding this comment.
So a compromise if displaying the original text, 'Login failed, possibly invalid credentials.' augmented with the server feedback (which might provide additional detail depending on error)?
There was a problem hiding this comment.
And normally I wouldn't press on this matter, but my 👃 is in a bz right now where not showing the full error message issssssss no bueno https://bugzilla.redhat.com/show_bug.cgi?id=1498984
| exception.catch('Login failed, possibly invalid credentials.') | ||
| .catch((response) => { | ||
| if (response.status === 401) { | ||
| vm.credentials.password = '' |
There was a problem hiding this comment.
should vm.credentials.login also be cleared out?
There was a problem hiding this comment.
I realize ref was for only password to be blank, but if it was an unsuccessful login attempt :-/
There was a problem hiding this comment.
The RFE just requested password be cleared out.
| .catch((response) => { | ||
| if (response.status === 401) { | ||
| vm.credentials.password = '' | ||
| Notifications.message('danger', '', __('Incorrect username or password.'), false) |
There was a problem hiding this comment.
So a compromise if displaying the original text, 'Login failed, possibly invalid credentials.' augmented with the server feedback (which might provide additional detail depending on error)?
|
Checked commits https://github.com/chalettu/manageiq-ui-service/compare/39198558665d9a6bfb1b0fb0be27b977a4f39288~...f12dd5a69cc8a780c4ea63dfbad50b75464fee3c with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
@miq-bot add_label enhancement
@miq-bot add_label fine/no