Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EUWE] Adjust show/hide cockpit attribute gate to supports_cockpit? #1163

Merged
merged 1 commit into from Oct 26, 2017

Conversation

AllenBW
Copy link
Member

@AllenBW AllenBW commented Oct 26, 2017

@miq-bot miq-bot changed the title Adjust show/hide cockpit attribute gate to supports_cockpit? [EUWE] Adjust show/hide cockpit attribute gate to supports_cockpit? Oct 26, 2017
@miq-bot
Copy link
Member

miq-bot commented Oct 26, 2017

Checked commit AllenBW@1c89bad with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@simaishi simaishi removed the euwe/yes label Oct 26, 2017
@chriskacerguis
Copy link
Contributor

@simaishi this is good to merge (you can ignore the NSP fail)

@chriskacerguis
Copy link
Contributor

@AllenBW do we need to ask the server for that decorator?

@AllenBW
Copy link
Member Author

AllenBW commented Oct 26, 2017

@chriskacerguis already done https://github.com/AllenBW/manageiq-ui-service/blob/1c89bad866695a5cf39d68296832155a5f874cf5/client/app/states/services/details/details.state.js

as part of the work in #1132

@chriskacerguis
Copy link
Contributor

@AllenBW thanks. just checking :)

@simaishi simaishi merged commit 678c9b8 into ManageIQ:euwe Oct 26, 2017
@simaishi simaishi added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 26, 2017
@AllenBW AllenBW deleted the BZ/#1471158-supports-cockpit branch October 26, 2017 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants