BZ#1517101-Adds empty state to service details relationship section #1292
Conversation
|
@serenamarie125 any chance we can get your eyes on this today? 🙇♀️ ❤️ |
|
Hey @AllenBW - in this case, is it that there is no info available or that no relationships exist? |
|
@serenamarie125 That there is no info available 👍 |
There was a problem hiding this comment.
Please change the text of the empty state pattern to be "No data available", as that matches what we use in other areas.
I think it's an issue that we are showing "No data available" rather than reporting that no relationships exist. But from what you are saying, you don't know the difference between no relationships and you got nothing, so we don't have a choice. @Loicavenel fyi
|
@serenamarie125 Was that the last issue? Can we |
| @@ -32,6 +32,7 @@ function ComponentController ($stateParams, $state, $window, CollectionsApi, Eve | |||
| availableTags: [], | |||
| credential: {}, | |||
| listActions: [], | |||
| emptyState: {icon: 'pficon pficon-help', title: 'No data available'}, | |||
There was a problem hiding this comment.
Missing i18n? (since it is in the other emptyState)
(and for those getInfo / provInfo messages?)
AllenBW
force-pushed
the
BZ/MASTER/#1517101-service-details-relationship-empty-state
branch
from
6ab9624
to
a7ae903
Compare
|
@serenamarie125 Wording has been update, following screenshots reflect current wording |
| @@ -371,7 +371,9 @@ <h2 translate>Resources</h2> | |||
| <div class="panel-body"> | |||
| <section> | |||
| <h2 translate>Relationships</h2> | |||
| <div class="container-fluid"> | |||
| <pf-empty-state ng-if="!vm.service.parent_service || !vm.service.service_template" config="vm.emptyState"></pf-empty-state> | |||
There was a problem hiding this comment.
&& not ||
(because negating a || b gives !a && !b ;)
There was a problem hiding this comment.
(Unless the goal was really to display "No data available" even if only one of those is missing, but that looks weird, with the list right under it.)
There was a problem hiding this comment.
good call on the &&!!
updated the pr
|
@miq-bot add_labels ux/review |
|
@miq-bot add_labels ux/approved |
AllenBW
force-pushed
the
BZ/MASTER/#1517101-service-details-relationship-empty-state
branch
from
a7ae903
to
ed8ce3c
Compare
AllenBW
force-pushed
the
BZ/MASTER/#1517101-service-details-relationship-empty-state
branch
from
ed8ce3c
to
fea7953
Compare
|
Almost LGTM 👍 Except, oops, one more broken thing..
When you have a service with just Looks like somebody forgot to adjust
@AllenBW is that something you want to fix in this PR or is this unrelated? |
|
Checked commits AllenBW/manageiq-ui-service@a39f37e~...06063c0 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
DANG @himdel fantastic catch <3
Updated, looks like we were missing a |
|
Perfect @AllenBW thanks! :) Retested, merging when green.. |
AllenBW
deleted the
BZ/MASTER/#1517101-service-details-relationship-empty-state
branch
…ils-relationship-empty-state BZ#1517101-Adds empty state to service details relationship section (cherry picked from commit 915ac21) https://bugzilla.redhat.com/show_bug.cgi?id=1524716
|
Gaprindashvili backport details: |
https://bugzilla.redhat.com/show_bug.cgi?id=1517101
When no relationship information was available, we were showing the title with an empty body (made it look like a bug). This fix adds the pf-empty state to the body that clearly indicates no information is available
After (two examples, cuz its nice to see different types)
Before (two examples, cuz its nice to see different types)