Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FINE] AuthenticationApi factory - fix fine-specific linter issues #1434

Merged
merged 1 commit into from
May 18, 2018
Merged

[FINE] AuthenticationApi factory - fix fine-specific linter issues #1434

merged 1 commit into from
May 18, 2018

Conversation

himdel
Copy link
Contributor

@himdel himdel commented May 18, 2018

Since the fine backport of #1411, the tests are failing in the linter phase.

This should fix it.

Since the fine backport of #1411, the tests are failing in the linter phase.

This should fix it.
@himdel himdel changed the title AuthanticationApi factory - fix fine-specific linter issues [FINE] AuthenticationApi factory - fix fine-specific linter issues May 18, 2018
Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 🌮

@miq-bot
Copy link
Member

miq-bot commented May 18, 2018

Checked commit https://github.com/himdel/manageiq-ui-service/commit/b867e2b5d76b57eeb24a1b88392e3a271fad17b8 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@simaishi simaishi merged commit c8d72ec into ManageIQ:fine May 18, 2018
@simaishi simaishi added this to the Sprint 86 Ending May 21, 2018 milestone May 18, 2018
@himdel himdel deleted the lint-base64 branch May 18, 2018 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants