Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes unsupported node 6 test env, updates yarn #1470

Merged
merged 1 commit into from
Aug 27, 2018

Conversation

AllenBW
Copy link
Member

@AllenBW AllenBW commented Aug 15, 2018

When yer title says it all.... doing this cuz 👉 ManageIQ/manageiq-v2v#533 (comment) 😋

@AllenBW AllenBW added this to the Sprint 93 Ending Aug 27, 2018 milestone Aug 15, 2018
@himdel
Copy link
Contributor

himdel commented Aug 15, 2018

@AllenBW maybe one more thing.. package.json still mentions 6.9.1

(we changed that to 8.9.0 for ui-classic, in ManageIQ/manageiq-ui-classic#4429)

@AllenBW
Copy link
Member Author

AllenBW commented Aug 15, 2018

Goooooood call, gonna do 5.10.0 for npm cuz that's whats packaged with 8.9.0

@miq-bot
Copy link
Member

miq-bot commented Aug 15, 2018

Checked commit AllenBW@580deee with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

Copy link
Contributor

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 matches the same change in ui-classic

@AllenBW
Copy link
Member Author

AllenBW commented Aug 24, 2018

@himdel any chance we could merge this orrrr does it require more work?

@himdel
Copy link
Contributor

himdel commented Aug 24, 2018

Oh, I'd love to... but.. I guess we really need to disable the github merging limitations :(

pr1470

@himdel
Copy link
Contributor

himdel commented Aug 24, 2018

@AllenBW would you object to just using the same github settings here as in ui-classic?

@AllenBW
Copy link
Member Author

AllenBW commented Aug 27, 2018

@himdel GOODNESS YES PLEASE DO THIS THING I don't have repo rights to fiddle with that stuff, but this thing, the requiring all checks, and checks getting stuck thing, its bitten us too many times

@himdel
Copy link
Contributor

himdel commented Aug 27, 2018

I don't have The Power either, but pinged @Fryguy :)

@AllenBW AllenBW merged commit 5941ab6 into ManageIQ:master Aug 27, 2018
@AllenBW AllenBW deleted the updates-travis branch August 27, 2018 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants