-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes unsupported node 6 test env, updates yarn #1470
Conversation
@AllenBW maybe one more thing.. (we changed that to 8.9.0 for ui-classic, in ManageIQ/manageiq-ui-classic#4429) |
28b83e7
to
580deee
Compare
Goooooood call, gonna do 5.10.0 for npm cuz that's whats packaged with 8.9.0 |
Checked commit AllenBW@580deee with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 matches the same change in ui-classic
@himdel any chance we could merge this orrrr does it require more work? |
@AllenBW would you object to just using the same github settings here as in ui-classic? |
@himdel GOODNESS YES PLEASE DO THIS THING I don't have repo rights to fiddle with that stuff, but this thing, the requiring all checks, and checks getting stuck thing, its bitten us too many times |
I don't have The Power either, but pinged @Fryguy :) |
When yer title says it all.... doing this cuz 👉 ManageIQ/manageiq-v2v#533 (comment) 😋