[WIP] PowerOperations - split VM logic from Service logic, fix #1580
Conversation
miq-bot
changed the title
|
This pull request has been automatically closed because it has not been updated for at least 3 months. Feel free to reopen this pull request if these changes are still valid. Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation. |
|
This pull request has been automatically closed because it has not been updated for at least 3 months. Feel free to reopen this pull request if these changes are still valid. Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation. |
can't do __(string + var), the error message needs to be added after the first string is translated
PowerOperations deals with Services or VMs, but the logic is different in each. Moving startVm, stopVm, suspendVm and retireVm actions to a separate VmPower service. (the allow*vm actions will follow..)
including vm related response stubs
remove all the unused helper functions, changing the functions to simply match the list of states against what getPowerState returns
|
Checked commits https://github.com/himdel/manageiq-ui-service/compare/dadec26dba494bdc6a2f154a7245f3a7c3add719~...e3d43cb601c5a62a9a144b6f5af95740272167ea with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation. |
|
This pull request has been automatically closed because it has not been updated for at least 3 months. Feel free to reopen this pull request if these changes are still valid. Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation. |
PowerOperations service currently deals with both VMs and Services.
That's making the code much less obvious, leading to bugs like passing a vm and service interchangeably to those functions, even though they don't use the same logic.
Splitting into separate VmPower and ServicePower services and cleaning up.
@miq-bot add_label wip, bug, ivanchuk/yes
This should make sure both VM views get the right start/stop/suspend/retire logic,
and the service view will as well.
https://bugzilla.redhat.com/show_bug.cgi?id=1704221