[HAMMER] DialogUser - use DialogData.outputConversion before submit and refresh #1609
Conversation
right now, when submitting a service dialog, we simply take the dialogData object, convert to JSON and send to the API. To allow for output conversions, adding a DialogData.outputConversion method, which should return the dialogData in a suitable format. (Right now, all this really means is that it converts Dates to strings before JSON stringification.) https://bugzilla.redhat.com/show_bug.cgi?id=1744413 (cherry picked from commit 247665a)
also, we can get rid of the API angular promise to Promise conversion with the $scope.$apply() removal in dialogUser.ts in ui-components https://bugzilla.redhat.com/show_bug.cgi?id=1744413 (cherry picked from commit 1ea47e6)
(cherry picked from commit eb98695)
those methods are used by ui-components code, needed in test env too
use eslint-loader instead of standard-loader, move config to .eslintrc.js and .eslintignore, use eslint in vet, remove Standard link from README (manual cherry-pick of 02ca0e4 - package.json had the tooling still in dependencies, instead of devDependencies) (cherry picked from commit 959ee94) and updated yarn.lock
|
Checked commits https://github.com/himdel/manageiq-ui-service/compare/2521dce78e058d5e98e8b9bbaf13dd59f4b1338f~...8be31a755f35dc9532e4c882d39f3082b1d9e59d with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@himdel 5.10.z build is now failing: I see So the question is... should webpack (and possibly other packages) stay in |
|
Aaah, sorry about this, you should switch to running without (The difference is that ManageIQ/manageiq-appliance-build#342 removed ( |
|
@himdel thanks, I'll backport the appliance-build PR. |
Hammer version of #1595
With most of #1607 (#1591)
And array-includes shim (originally added in #1566)
And package.json cleanup originally added in #1576
Depends on ManageIQ/ui-components#422 (via #1608, merged)Right now, when submitting a service dialog,
we simply take the dialogData object, convert to JSON and send to the API.
To allow for output conversions, adding a DialogData.outputConversion method,
which should return the dialogData in a suitable format.
(Right now, all this really means is that it converts Dates to strings before JSON stringification.)
And the same needs to happen in refreshField for dynamic fields.
https://bugzilla.redhat.com/show_bug.cgi?id=1768457
@miq-bot add_label bug