Fix build after merge of Node 18 #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
commented
Apr 7, 2023
| @@ -7140,25 +7140,26 @@ fsevents@^1.2.7: | |||
| bindings: ^1.5.0 | |||
| nan: ^2.12.1 | |||
| checksum: ae855aa737aaa2f9167e9f70417cf6e45a5cd11918e1fee9923709a0149be52416d765433b4aeff56c789b1152e718cd1b13ddec6043b78cdda68260d86383c1 | |||
| conditions: os=darwin | |||
There was a problem hiding this comment.
this is really interesting - not sure exactly what it means when we try to build on a non-macOS system.
|
So this is now red because of the node-sass thing in #1834 , but that one is failing on this issue, so they are co-dependent. Thinking we should merge this one first, @MelsHyrule WDYT? |
|
@MelsHyrule I'm trying something fancy and merging #1834 into this PR branch 😮 |
Fryguy
force-pushed
the
upgrade_yarn
branch
2 times, most recently
from
23d30ba
to
7d6935e
Compare
This commit is similar to ManageIQ/manageiq-ui-classic#8747
|
Ok, I merged #1834 and rebased this PR. I expect this to now go green. |
|
Tested and LGTM |
MelsHyrule
approved these changes
Apr 11, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MelsHyrule Please review - I think this should fix master now that we are on node 18.
If this works I'll send out updates across the board.