[EUWE] Pull in the real power_state column off of service #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 9, 2016
| powerOperationInProgressState: function(item) { | ||
| return (item.power_state !== "timeout" && item.options.power_status === "starting") | ||
| || (item.power_state !== "timeout" && item.options.power_status === "stopping") | ||
| || (item.power_state !== "timeout" && item.options.power_status === "suspending"); |
houndci-bot
reviewed
Dec 9, 2016
| || (item.powerState !== "timeout" && item.powerStatus === "suspending"); | ||
| powerOperationInProgressState: function(item) { | ||
| return (item.power_state !== "timeout" && item.options.power_status === "starting") | ||
| || (item.power_state !== "timeout" && item.options.power_status === "stopping") |
houndci-bot
reviewed
Dec 9, 2016
| || (item.powerState !== "timeout" && item.powerStatus === "suspending"); | ||
| return (item.power_state !== "timeout" && item.options.power_status === "starting") | ||
| || (item.power_state !== "timeout" && item.options.power_status === "stopping") | ||
| || (item.power_state !== "timeout" && item.options.power_status === "suspending"); |
houndci-bot
reviewed
Dec 9, 2016
| || (item.powerState !== "timeout" && item.powerStatus === "stopping") | ||
| || (item.powerState !== "timeout" && item.powerStatus === "suspending"); | ||
| return (item.power_state !== "timeout" && item.options.power_status === "starting") | ||
| || (item.power_state !== "timeout" && item.options.power_status === "stopping") |
houndci-bot
reviewed
Dec 9, 2016
| || (item.powerState !== "timeout" && item.powerStatus === "suspending"); | ||
| return (item.power_state !== "timeout" && item.options.power_status === "starting") | ||
| || (item.power_state !== "timeout" && item.options.power_status === "stopping") | ||
| || (item.power_state !== "timeout" && item.options.power_status === "suspending"); |
houndci-bot
reviewed
Dec 9, 2016
| || (item.powerState !== "timeout" && item.powerStatus === "stopping") | ||
| || (item.powerState !== "timeout" && item.powerStatus === "suspending"); | ||
| return (item.power_state !== "timeout" && item.options.power_status === "starting") | ||
| || (item.power_state !== "timeout" && item.options.power_status === "stopping") |
|
It's OK to ignore those hound violations (they are not valid. I always see them only on the Euwe branch) @chessbyte This is the Euwe equivalent of the Upstream PR #377 |
|
@chriskacerguis please review before I merge |
chriskacerguis
approved these changes
Dec 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls in the service.power_state directly from the virtual power_state column vs the cached version previously exposed in the options hash.
https://bugzilla.redhat.com/show_bug.cgi?id=1396728
This is Upstream equivalent of #377