Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated our yarn command and turned on caching #570

Merged
merged 1 commit into from Mar 8, 2017
Merged

Updated our yarn command and turned on caching #570

merged 1 commit into from Mar 8, 2017

Conversation

chalettu
Copy link
Contributor

@chalettu chalettu commented Mar 7, 2017

This is a proposed enhancement that would just have us use the regular yarn install command so we can leverage caching. This also turns on travis’s support for yarn caching

@chalettu
Copy link
Contributor Author

chalettu commented Mar 7, 2017

@miq-bot add_label enhancement
@miq-bot add_label euwe/no

@miq-bot
Copy link
Member

miq-bot commented Mar 7, 2017

Checked commit https://github.com/chalettu/manageiq-ui-service/commit/c2e936cdad0313114156c35cdc6fa0ac98b9fd6c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🏆

@chriskacerguis chriskacerguis self-assigned this Mar 8, 2017
@AllenBW AllenBW added this to the Sprint 56 Ending Mar 13, 2017 milestone Mar 8, 2017
Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 👍

@AllenBW
Copy link
Member

AllenBW commented Mar 8, 2017

I wanta add this thought to the record... 'Member when things are wonky with your build and blow away ./node_modules and fetch anew? So here we gain speed (of travis completion) at he cost of stability?

@chalettu
Copy link
Contributor Author

chalettu commented Mar 8, 2017

I here you about wonkiness and if it starts to become a regular problem we can easily switch it back. Travis also has a button that maintainers can hit that clears out stored cache if we ever want to flush it.

@chriskacerguis chriskacerguis merged commit 5325b81 into ManageIQ:master Mar 8, 2017
@chalettu chalettu deleted the travis-yarn-tuning branch December 20, 2017 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants