BZ#1446405-Update skinning documentation #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indicate how to change 404 and order details logo
chriskacerguis
approved these changes
Apr 28, 2017
|
Checked commit AllenBW@cf500bf with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
chriskacerguis
approved these changes
Apr 29, 2017
simaishi
pushed a commit
that referenced
this pull request
May 1, 2017
BZ#1446405-Update skinning documentation (cherry picked from commit e147a2f) https://bugzilla.redhat.com/show_bug.cgi?id=1447051
|
Fine backport details: |
|
@AllenBW @chriskacerguis this change is requested to be backported to Euwe branch. Would that be a problem? |
|
@simaishi nope! they picked a good one to backport with one exception, euwe has an additional mention of the image https://github.com/manageiq/manageiq-ui-service/blob/6a3dc554677c1294f4662112aff29e0b20ebe1af/client/app/states/requests/orders/orders.html#L14 SOOOOO to catch all maybe we should do a euwe specific pr? @chriskacerguis thoughts? |
|
Yeah, I think a euwe specific one makes sense. |
AllenBW
added a commit
to AllenBW/manageiq-ui-service
that referenced
this pull request
Jun 13, 2017
This was referenced Jun 13, 2017
|
Backported to Euwe via #817 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1446405
https://www.pivotaltracker.com/story/show/144545827
Indicate how to change 404 and order details logo