Merge pull request #11688 from romanblanco/toolbar_button_refactoring…

…_scan_item_set Removed unused toolbar buttons from toolbar builder
ManageIQ · Oct 5, 2016 · 18195e2 · 18195e2
2 parents a8d4838 + 686df7e
commit 18195e2
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 32 deletions.
diff --git a/app/helpers/application_helper/toolbar_builder.rb b/app/helpers/application_helper/toolbar_builder.rb
@@ -706,13 +706,6 @@ def build_toolbar_hide_button(id)
       when "miq_template_refresh", "miq_template_reload"
         return true unless @perf_options[:typ] == "realtime"
       end
-    when "ScanItemSet"
-      case id
-      when "scan_delete"
-        return true if @record.read_only
-      when "scan_edit"
-        return true if @record.read_only
-      end
     when "ServerRole"
       case id
       when "server_delete", "role_start", "role_suspend", "promote_server", "demote_server"

diff --git a/spec/helpers/application_helper/toolbar_builder_spec.rb b/spec/helpers/application_helper/toolbar_builder_spec.rb
@@ -773,31 +773,6 @@ def method_missing(sym, *args)
       end
     end
 
-    context "when with ScanItemSet" do
-      before do
-        @record = ScanItemSet.new
-        stub_user(:features => :all)
-      end
-
-      ["scan_delete", "scan_edit"].each do |id|
-        context "and id = #{id}" do
-          before do
-            @id = id
-            allow(@record).to receive_messages(:read_only => false)
-          end
-
-          it "and record read only" do
-            allow(@record).to receive_messages(:read_only => true)
-            expect(subject).to be_truthy
-          end
-
-          it "and record not read only" do
-            expect(subject).to be_falsey
-          end
-        end
-      end
-    end
-
     context "when with ServerRole" do
       before do
         @record = ServerRole.new