Drop the global vmware remote console type setting

https://bugzilla.redhat.com/show_bug.cgi?id=1532720

app/models/vm.rb

@@ -164,8 +164,4 @@ def cockpit_support
       :message => unsupported_reason(:launch_cockpit)
     }
   end
-
-  def console_supports_type?(console_type)
-    Settings.server.remote_console_type.upcase == console_type.upcase ? console_supported?(console_type) : false
-  end
 end

app/models/vm/operations.rb

@@ -12,7 +12,7 @@ module Vm::Operations
     supports :vnc_console do
       message = "VNC Console not supported"
       if vendor == 'vmware'
-        unsupported_reason_add(:vnc_console, message) unless ext_management_system.present? && console_supports_type?('VNC')
+        unsupported_reason_add(:vnc_console, message) unless ext_management_system.present? && console_supported?('VNC')
       elsif !console_supported?('VNC')
         unsupported_reason_add(:vnc_console, message)
       end
@@ -22,13 +22,13 @@ module Vm::Operations
       message = "WebMKS Console not supported"
       if vendor != 'vmware'
         unsupported_reason_add(:mks_console, message)
-      elsif console_supported?('WEBMKS') && !console_supports_type?('WebMKS')
+      elsif console_supported?('WEBMKS') && !console_supported?('WebMKS')
         unsupported_reason_add(:mks_console, message)
       end
     end
 
     supports :vmrc_console do
-      unsupported_reason_add(:vmrc_console, "VMRC Console not supported") unless console_supports_type?('VMRC')
+      unsupported_reason_add(:vmrc_console, "VMRC Console not supported") unless console_supported?('VMRC')
     end
 
     supports :spice_console do

config/settings.yml

@@ -1008,7 +1008,6 @@
   :prefetch_min_per_worker_dequeue: 10
   :prefetch_stale_threshold: 30.seconds
   :rails_server: puma
-  :remote_console_type: VMRC
   :role: database_operations,event,reporting,scheduler,smartstate,ems_operations,ems_inventory,user_interface,remote_console,web_services,automate
   :server_dequeue_frequency: 5.seconds
   :server_log_frequency: 5.minutes

spec/models/vm/operations_spec.rb

@@ -63,7 +63,7 @@
   context '#supports_vnc_console?' do
     it 'does not support it for vmware vms if it is not the specified console type in settings' do
       allow(@vm).to receive(:vendor).and_return('vmware')
-      allow(@vm).to receive(:console_supports_type?).with('VNC').and_return(false)
+      allow(@vm).to receive(:console_supported?).with('VNC').and_return(false)
 
       expect(@vm.supports_vnc_console?).to be_falsey
       expect(@vm.unsupported_reason(:vnc_console)).to include('VNC Console not supported')
@@ -80,7 +80,6 @@
     it 'supports it if all conditions are met' do
       server = double
       allow(Settings).to receive(:server).and_return(server)
-      allow(server).to receive(:remote_console_type).and_return('VNC')
 
       expect(@vm.supports_vnc_console?).to be_truthy
     end
@@ -96,7 +95,7 @@
 
     it 'supports it if all conditions are met' do
       allow(@vm).to receive(:console_supported?).with('WEBMKS').and_return(true)
-      allow(@vm).to receive(:console_supports_type?).with('WebMKS').and_return(true)
+      allow(@vm).to receive(:console_supported?).with('WebMKS').and_return(true)
 
       expect(@vm.supports_mks_console?).to be_truthy
     end
@@ -173,29 +172,29 @@
 
   context '#supports_vmrc_console?' do
     it 'returns false if type is not supported' do
-      allow(@vm).to receive(:console_supports_type?).with('VMRC').and_return(false)
+      allow(@vm).to receive(:console_supported?).with('VMRC').and_return(false)
 
       expect(@vm.supports_vmrc_console?).to be_falsey
       expect(@vm.unsupported_reason(:vmrc_console)).to include('VMRC Console not supported')
     end
 
     it 'supports it if all conditions are met' do
-      allow(@vm).to receive(:console_supports_type?).with('VMRC').and_return(true)
+      allow(@vm).to receive(:console_supported?).with('VMRC').and_return(true)
 
       expect(@vm.supports_vmrc_console?).to be_truthy
     end
   end
 
   context '#supports_spice_console?' do
     it 'returns false if type is not supported' do
-      allow(@vm).to receive(:console_supports_type?).with('SPICE').and_return(false)
+      allow(@vm).to receive(:console_supported?).with('SPICE').and_return(false)
 
       expect(@vm.supports_spice_console?).to be_falsey
       expect(@vm.unsupported_reason(:spice_console)).to include('Spice Console not supported')
     end
 
     it 'supports it if all conditions are met' do
-      allow(@vm).to receive(:console_supports_type?).with('SPICE').and_return(true)
+      allow(@vm).to receive(:console_supported?).with('SPICE').and_return(true)
 
       expect(@vm.supports_spice_console?).to be_truthy
     end