Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: prototype -> jquery - replace ajax calls #1150

Closed
bmclaughlin opened this issue Dec 2, 2014 · 2 comments
Closed

UI: prototype -> jquery - replace ajax calls #1150

bmclaughlin opened this issue Dec 2, 2014 · 2 comments
Assignees

Comments

@bmclaughlin
Copy link
Contributor

Replace prototype ajax calls: Ajax.Request with jQuery ajax calls: $j.ajax

prototype ajax documentation
jQuery ajax documentation

Parent issue: #214

h-kataria added a commit to h-kataria/manageiq that referenced this issue Dec 16, 2014
- Replaced occurrences of Ajax.Request to $j.ajax
- Changed default type for ajax calls to be "POST", this was "GET" by default.
- Changed occurrences or "Parameters" on ajax calls to "data", jquery expects "data" to be present that it uses to convert to a querystring and send it upto the server.
- Changed miq_dhtmlxtoolbar.js to strip out "?" from the params that is the first character in the button.url_parms string, jquery expects data to be a key/value pair.

Issue ManageIQ#1150
@dclarizio
Copy link

@bmclaughlin Please verify that the merged PR closes this issue. Thx, Dan

@bmclaughlin
Copy link
Contributor Author

@dclarizio Confirmed, PR closes this issue.

h-kataria added a commit to h-kataria/manageiq that referenced this issue Dec 23, 2014
Fixed an issue introduced in ManageIQ#1150 PR, encoding of URL for forms was causing an issue if user entered empty space or other characters in the form fields. Added a setting to be passed in to miqJqueryRequest method when url does not need to be encoded.
@Fryguy Fryguy added this to the Sprint 17 Ending Jan 5, 2014 milestone Jan 6, 2015
h-kataria added a commit to h-kataria/manageiq that referenced this issue Jan 14, 2015
- Removed any extra miqSparkle On/Off calls from jquery requests that were added in this ManageIQ#1225 PR.
- Added code back to turn spinner on/off if it was set in the check_box_tag

ManageIQ#1150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants