rake test:javascript should fail if the JS engine crashes

[himdel]

Between #11762 and #12640, our JS tests would crash the phantomjs server (infinite loop leads to a Segmentation fault), but the test suite would still pass.

That's bad, if phantomjs crashes, the rake task should too.

$ git log -1 --oneline
638f4d7 Merge pull request #12424 from tinaafitz/notification_provisioned

$ rake test:javascript ; echo STATUS: $?
Puma starting in single mode...
* Version 3.3.0 (ruby 2.3.1-p112), codename: Jovial Platypus
* Min threads: 5, max threads: 5
* Environment: development
* Listening on tcp://0.0.0.0:40227
Use Ctrl-C to stop
jasmine server started
...............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................1   0x1b67967 /home/himdel/.phantomjs/2.1.1/x86_64-linux/bin/phantomjs() [0x1b67967]
2   0x1baac35 /home/himdel/.phantomjs/2.1.1/x86_64-linux/bin/phantomjs() [0x1baac35]
3   0x1b9369c /home/himdel/.phantomjs/2.1.1/x86_64-linux/bin/phantomjs() [0x1b9369c]
4   0x18970ad /home/himdel/.phantomjs/2.1.1/x86_64-linux/bin/phantomjs() [0x18970ad]
5   0x1896ace /home/himdel/.phantomjs/2.1.1/x86_64-linux/bin/phantomjs() [0x1896ace]
6   0x1896ddf /home/himdel/.phantomjs/2.1.1/x86_64-linux/bin/phantomjs() [0x1896ddf]
7   0x1907ec8 /home/himdel/.phantomjs/2.1.1/x86_64-linux/bin/phantomjs() [0x1907ec8]
8   0x7f0133d1d801 [0x7f0133d1d801]
PhantomJS has crashed. Please read the bug reporting guide at
<http://phantomjs.org/bug-reporting.html> and file a bug report.
Segmentation fault

703 specs, 0 failures
STATUS: 0

[dclarizio]

@miq-bot assign @himdel

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

[himdel]

@miq-bot move_issue ManageIQ/manageiq-ui-classic

[miq-bot]

This issue has been moved to ManageIQ/manageiq-ui-classic#2278