More precise tooltip values in C&U charts #12640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanSpagetka
changed the title
PanSpagetka
force-pushed
the
cu-charts-more-precise-tooltip
branch
from
75de93a
to
b5cb7dc
Compare
|
@PanSpagetka this seems to have caused some number formatting failures in the JS tests. |
PanSpagetka
force-pushed
the
cu-charts-more-precise-tooltip
branch
from
b5cb7dc
to
821fb43
Compare
|
@PanSpagetka there is a seemingly unrelated JS test failure, perhaps a rebase? |
PanSpagetka
force-pushed
the
cu-charts-more-precise-tooltip
branch
2 times, most recently
from
a066ea6
to
147fedc
Compare
PanSpagetka
force-pushed
the
cu-charts-more-precise-tooltip
branch
from
147fedc
to
c57c0ab
Compare
|
Checked commits PanSpagetka/manageiq@74e6b61~...c57c0ab with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
When backporting, please backport #12782 right after this one. |
simaishi
pushed a commit
that referenced
this pull request
Jan 24, 2017
…ltip More precise tooltip values in C&U charts (cherry picked from commit 5283c97) https://bugzilla.redhat.com/show_bug.cgi?id=1416093
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we have charts with values which are really close to each other(like in first picture) and they are rounded. Our formatting functions are generated when the charts is build, so it is possible to adjust precision of labels base on actual values, but...
Charts are dynamic, you can show/hide individual series of data and chart adapt to this changes(second picture) for this case it would be hard to change dynamically precision on labels base on data which is actually shown.
So I decided use something more simple, in tooltip just show more precise values.
Screenshots
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1383821
Steps for Testing/QA
Goto: Compute -> Infrastructure -> Host/VM/Cluster -> Utilization