Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Remove Date button (the X) on VM Reitrement is not working. #1384

Closed
h-kataria opened this issue Jan 15, 2015 · 2 comments
Closed

UI: Remove Date button (the X) on VM Reitrement is not working. #1384

h-kataria opened this issue Jan 15, 2015 · 2 comments
Assignees
Labels

Comments

@h-kataria
Copy link
Contributor

An existing (in master) issue is that when pressing the Remove button (the X), no transaction is sent up to clear the retirement date, but the text box is cleared on the screen. If Save is hit at this point, the retirement date is set even though the user meant to clear it.

Remove button (the X) does not go away after the date is cleared. Most likely due to the first issue above since the server may be sending down the JS to hide it, but I'm not sure.

It looks like that JS command in link_to_function in views/vm_common/_retire HAML view is not working, When pressing the button it doesn't send up the transaction to server. This is working on 5.3.z. It looks like this issue was introduced during HAML conversion.

@skateman
Copy link
Member

The problem wasn't caused by the HAML, but by this:
e5be63e#diff-72eafb293c59edc3cf6f4244d1852374R830
@miq-bot assign @martinpovolny

@h-kataria h-kataria assigned h-kataria and unassigned skateman Jan 16, 2015
h-kataria added a commit to h-kataria/manageiq that referenced this issue Jan 19, 2015
- Added code to trigger change event when Retirement date remove button is pressed and and miq_Date_1 value is cleared out. Changed JS code to send up transaction to server when change event is triggered, moved code that sends request upto server into a separate function so it can be called for both onclick and change events.

ManageIQ#1384
@h-kataria
Copy link
Contributor Author

Fixed by #1397

@martinpovolny martinpovolny added this to the Sprint 19 Ending Feb 16, 2015 milestone Feb 4, 2015
@miq-bot miq-bot assigned martinpovolny and unassigned h-kataria Feb 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants