heat client don't populate correctly the "files" parameter

[ioggstream]

Reproduce

Create an Orchestration template that references external files:

heat_template_version: newton

resources:
  a_file:
    type: https://gist.githubusercontent.com/ioggstream/55135a3c886802dedaac833ce4f87bfa/raw/b320d97756da702797d76b85b0a8c630d5589889/case_01891685.yaml

 #  https://pastebin.com/raw/hVbif6z9
 # the linked resource references get_file: https://www.google.com/robots.txt

I expect

• the stack to be created

Instead

• I got an error
• Heat complains about get_file: https://www.google.com/robots.txt not in the files dict
• getting the files dict from heat, the file is not there

openstack stack files list mystack
...
NO https://www.google.com/robots.txt around

The error is probably the MIQ counterpart of the horizon one https://bugs.launchpad.net/horizon/+bug/1467781

[ioggstream]

@bzwei which is the miq code in charge for calling the stack?

[bzwei]

@ioggstream https://github.com/ManageIQ/manageiq-providers-openstack/blob/master/app/models/manageiq/providers/openstack/cloud_manager/orchestration_stack.rb#L4

service.stacks.new.save(create_options)["id"]

It uses fog gem to create stack

[ioggstream]

@bzwei We need to fix fog gem, right?

Here's the Heat API reference https://developer.openstack.org/api-ref/orchestration/v1/index.html?expanded=create-stack-detail#stacks

And here's the fog/fog-openstack file

• there's no files parameter https://github.com/fog/fog-openstack/blame/master/lib/fog/orchestration/openstack/models/stack.rb#L9

• there's no files resolution here https://github.com/fog/fog-openstack/blob/master/lib/fog/orchestration/openstack/requests/create_stack.rb

[ioggstream]

@bzwei here's a stub of file gathering. It's my first ruby code... @suuuper shouldn' t be hard to make it work for http resources too. .https://gist.github.com/ioggstream/bedea98dc53aa61b0ebd48cd1bb73486

[bzwei]

@ioggstream Thanks for all the findings. We now have sufficient information to fix the problem, just need to find a time.

[ioggstream]

@bzwei as we're on cloudforms is there an easy way to apply the patch once you release it?

[bzwei]

@ioggstream Is this an urgent issue? We don't have the capacity to fix the problem right now, likely until September.
I also see template having get_file is an embedded template. If we scan the master template we will not find these files.

[ioggstream]

@bzwei afaik a cloudforms' case have been open on that -

This updated snippet - very simple and without proper error handling - should resolve get_file in nested templates https://gist.github.com/ioggstream/bedea98dc53aa61b0ebd48cd1bb73486

Here's the python-heatclient implementation

https://github.com/openstack/python-heatclient/blob/master/heatclient/common/template_utils.py#L103

[bzwei]

@ioggstream Is there a link to the CloudForms' case? We also need a bugzilla RFE to track the work.

[lmiccini]

@bzwei https://bugzilla.redhat.com/show_bug.cgi?id=1471948 , case is linked to the BZ.

[ioggstream]

@bzwei I'm working on that. Feedback welcome on fog/fog-openstack#317

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

[bzwei]

This issue should be closed since it has been resolved by fog/fog-openstack#317.

[JPrause]

@miq-bot close_issue