manageiq log folder and dirty git

[ghost]

No description provided.

[agrare]

I'm guessing that you did a git clean -fdx or some equivalent?

Yeah it looks like we don't have a log/.keep file which would be a nice addition, you want to put in a pull request to add this?

[agrare]

@sckhg1367 did you put a PR in?

[Fryguy]

We intentionally don't have the .keep file. If I recall it's because on the appliance we replace the log directory with a mount point, to allow bigger disks. If the .keep file is there, then the git instance on the appliance is in an always-dirty state.

[Fryguy]

See #17663

[Fryguy]

Reopening @agrare

[Fryguy]

It seems that the rationale for having a clean git history was broken by ManageIQ/manageiq-appliance-build@3fb3528#diff-59d2b58eb2d092c0658886c3db5af71dR17 , and we should just fix the clean git history on the appliance

cc @kbrock

[kbrock]

@Fryguy Git does not track directories, it only tracks files. So if there are not files under log/ checked into git, then git should not be aware of log.

Why would a symbolic link cause a stale git state?
Seems it would say "added file" but it should allow us to change branches and stash and stuff. no?

[agrare]

@kbrock because a symlink is a file

[kbrock]

@agrare ok, so git knows the file is there, but it is not tracking it. so you can stash pop, checkout a different branch and you don't have to deal with a deleted file log/.keep

Maybe add log to .gitignore?

EDIT: ignore this, I looked at the PR. I'm good now