Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Throttle API requests #20955

Closed
Fryguy opened this issue Jan 13, 2021 · 3 comments
Closed

[RFE] Throttle API requests #20955

Fryguy opened this issue Jan 13, 2021 · 3 comments
Assignees
Projects
Milestone

Comments

@Fryguy
Copy link
Member

Fryguy commented Jan 13, 2021

This enhancement request has a number of dimensions.

  • We should throttle successful logins for the same user when repeated too many times within a certain short amount of time. In doing so we can encourage the usage of logging in to get a token and then using that token in follow-up calls. This will mitigate excessive logging and audit events.
  • We should throttle API requests in general (except maybe requests with a UI token?) to discourage unoptimized queries and N+1 errors. This would be akin to GitHub placing a limit of 5000 requests per hour. I suggest we do something similar, though I don't know what that number should be. Regardless, it should be configurable.

Note that we already throttle unsuccessful logins via a delayed lockout.

cc @jrafanie

@Fryguy Fryguy added this to To do in Roadmap Jan 13, 2021
@jrafanie
Copy link
Member

@NickLaMuro is this resolved by #21271 ? Can this or should this go back to morphy?

@chessbyte chessbyte moved this from To do to In progress in Roadmap Aug 25, 2021
@chessbyte chessbyte added this to the Morphy milestone Aug 25, 2021
@Fryguy Fryguy moved this from In progress to Morphy in Roadmap Sep 1, 2021
@Fryguy
Copy link
Member Author

Fryguy commented Sep 1, 2021

Done!

@Fryguy Fryguy closed this as completed Sep 1, 2021
@NickLaMuro
Copy link
Member

NickLaMuro commented Sep 1, 2021

Yes, this was resolved by #21271 as we discussed offline. Sorry for not coming back here and responding previously 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Roadmap
  
Morphy
Development

No branches or pull requests

5 participants