Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to update VM description #21561

Open
lamm opened this issue Nov 17, 2021 · 17 comments
Open

Add ability to update VM description #21561

lamm opened this issue Nov 17, 2021 · 17 comments
Assignees

Comments

@lamm
Copy link

lamm commented Nov 17, 2021

We are using kasparov-2 and we are looking for a way to modify the description field of a VM without going through the GUI ( button).
Is there a way to do this by an automation script ?
If not, would it be possible to add this functionality ?

@chessbyte
Copy link
Member

What provider are you looking to integrate this capability with?

@lamm
Copy link
Author

lamm commented Nov 17, 2021

We are using vmware provider.

@chessbyte
Copy link
Member

Is this capability supported in the VMware API? /cc @agrare

@agrare
Copy link
Member

agrare commented Nov 18, 2021

Sort of, VMware doesn't have a "description" exactly. They have a Notes field which the backend API calls "summary.config.annotations" [ref]. We parse this and store it in the vm.hardware.annotation column. It can be changed by issuing a ReconfigVM_Task API call.

Not clear to me why annotations are stored in hardware and not in Vm#description maybe @Fryguy remembers?

@chessbyte
Copy link
Member

Not clear to me why annotations are stored in hardware and not in Vm#description maybe @Fryguy remembers?

Just seems plain wrong, but maybe we had a reason that made sense at the time?

@agrare
Copy link
Member

agrare commented Nov 18, 2021

Yeah agreed, unless we have some requirement that Vm#description can't have newlines I don't see why we wouldn't just use notes as the vm description

@chessbyte
Copy link
Member

What PG type is Vm#description?

@agrare
Copy link
Member

agrare commented Nov 18, 2021

t.text "description", comment: "A description of the VM that is typically set by the provider, but may also be edited."

@chessbyte
Copy link
Member

I would propose fixing our refresher to store the VM's description in the proper field.

@lamm
Copy link
Author

lamm commented Nov 19, 2021

The use case here is the following.

We are using MIQ in multi-tenant configuration.

Our customers would like to be able to add a description on their VMs in order to be able to identify them more easily in the interface. The ideal would be to display this description in the grid which lists the VMs. We have therefore considered using the currently available "description" field to do this. The problem is that editing this field using the "configuration / edit this VM" button allows other modifications to be made than just the description of the VM.
image

The idea is to create a customize button allowing you to modify only the description. Unfortunately it is not possible to modify the description by code. That's why I opened this issue.

Next, since the description field is not displayed in the grid when listing the VMs, we will provide our customers with a custom filter that will allow them to search for VMs whose description contains a string they will enter.

I'm not sure if using the description field is the best option to deal with this use case or if there is a cleanest way to do it.

@Fryguy
Copy link
Member

Fryguy commented Dec 14, 2021

All of the provider PRs are merged. I think we just need API/UI support at this point.

@miq-bot
Copy link
Member

miq-bot commented Feb 27, 2023

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@Fryguy Fryguy removed the stale label Mar 2, 2023
@kbrock
Copy link
Member

kbrock commented Jul 13, 2023

Does the API pr linked above meet our needs. is this done?

@lamm
Copy link
Author

lamm commented Oct 9, 2023

We plan to upgrate to Oparin/Petrosian soon.
We will this test this new feature and make you a feedback.

@Fryguy
Copy link
Member

Fryguy commented Oct 11, 2023

@jeffibm Do we have UI for this? I see that the API was completed, but I don't see any UI changes. If not, can we add this?

@jeffibm
Copy link
Member

jeffibm commented Oct 27, 2023

@jeffibm Do we have UI for this? I see that the API was completed, but I don't see any UI changes. If not, can we add this?

Based on the previous discussion, we will raise a PR that gives the ability to update just the description in another form by making use of this API - ManageIQ/manageiq-api#1120
cc @kbrock

@miq-bot
Copy link
Member

miq-bot commented Jan 29, 2024

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants