Prefer abbreviation to oids to describe http method sets #10204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 ❤️ this. These would change if we ever save and reload the config file via YAML, but that really never happens so I'm good with this. Thanks !!! |
|
@abellotti I meant to ask you if that would ever happen, so thanks for anticipating! |
Out of context these ids can be disorienting - it should now be more obvious which verbs a collection is supporting at a glance
imtayadeway
force-pushed
the
refactor/api-yml-verb-collections
branch
from
c6ee60c
to
15af3c4
Compare
|
Checked commit imtayadeway@15af3c4 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
LGTM !! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
Out of context these ids can be disorienting - it should now be more
obvious which verbs a collection is supporting at a glance
@miq-bot add-label core, api, refactoring
@miq-bot assign @abellotti
/cc @gtanzillo