Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear text in Search box #10232

Closed
wants to merge 1 commit into from
Closed

Conversation

h-kataria
Copy link
Contributor

Purpose or Intent

Describe the rationale and use case for this pull request. Provide any background, examples, and images that provide further information to accurately describe what it is that you are adding to the repo. Add subsections as necessary to organize and feel free to link and reference other PRs as necessary, but also include them in the links section below as a quick reference.

Guidelines:

  • Keep Pull Request titles short and to the point, ideally under 72 characters
  • Provide as much context/info in the description as necessary to get the reviewer up to the same domain knowledge level as yourself
  • Keep code changes as short and implementing a single feature/bug fix/refactoring when possible

Links

Steps for Testing/QA

[Optional] If there are any manual steps that you would like the reviewer(s) to take to verify your changes, please describe in detail the steps to reproduce the features added by the pull request, or the bug before and after the change.

https://bugzilla.redhat.com/show_bug.cgi?id=1346996

@miq-bot
Copy link
Member

miq-bot commented Aug 3, 2016

Checked commit GregP@e89f19f with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
4 files checked, 2 offenses detected

app/controllers/application_controller.rb

app/controllers/application_controller/explorer.rb

# Clear out search text when clear when requested
def clear_search_text
@search_text = params[:search_text] = nil
end
Copy link
Member

@chessbyte chessbyte Aug 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this method should be indented to match the other methods in this file.

@h-kataria
Copy link
Contributor Author

closing this accidentally created PR, @GregP is working on these changes.

@h-kataria h-kataria closed this Aug 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants