Handle change event for checkboxes, not click
#10337
Conversation
himdel
changed the title
change event for checkboxes, not clickchange event for checkboxes, not click
|
@himdel For some reason, with your changes, when I navigate to: |
|
@mzazrivec .. ahh, thanks, now, I'm seeing it too.. investigating.. |
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
..because :servers_all is never set in :edit
to unify the different ways it was created
just render the cases to make the conditions simpler, and remove unused override
makes little sense to fix in this PR and may be nontrivial because onchange gets generated for the newly clicked radio *and* for the previously-checked radio
This is so that checkbox handlers do the correct thing even when the checkbox was checked by keyboard, etc. https://bugzilla.redhat.com/show_bug.cgi?id=1343659
|
OK, this fixes the bug.. I'm just not quite sure yet about all the places I've added triggering the change event to are really supposed to have it yet.. (8656dc8) |
|
.. pretty sure I've found the right combination .. triggering change on every checking that's not done from the backend and that does not change a check-all button itself. |
|
Checked commits https://github.com/himdel/manageiq/compare/c105919255a1ce69da394b9e699660bd21236327~...461c2ea4c1427da2e9ec04f8f2f5be773e91baee with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
Right now many of our checkboxes deal with the
clickevent, which is only triggered when clicking the checkbox by mouse, and may not be triggered when clicking the associated label, using keyboard, screenreader, etc..Especially they weren't triggered by setting
.prop('checked', truthy)inmiqUpdateAllCheckboxes..Updating to use the
changeevent instead..https://bugzilla.redhat.com/show_bug.cgi?id=1343659