Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete configuration provider when selected from tree does not work #10497

Merged
merged 2 commits into from Aug 18, 2016
Merged

Delete configuration provider when selected from tree does not work #10497

merged 2 commits into from Aug 18, 2016

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Aug 15, 2016 •
edited

Delete configuration provider when selected from tree does not work.

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1364966

Darga:

https://bugzilla.redhat.com/show_bug.cgi?id=1371311

@lgalis lgalis changed the title Delete configuration provider when selected from tree does not work [WIP] Delete configuration provider when selected from tree does not work Aug 15, 2016
@lgalis
Copy link
Contributor Author

lgalis commented Aug 15, 2016

@miq-bot add_label ui, wip, bug

@miq-bot
Copy link
Member

miq-bot commented Aug 15, 2016

Checked commits lgalis/manageiq@cff4530~...f5d3733 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
2 files checked, 0 offenses detected
Everything looks good. 🍪

@lgalis
Copy link
Contributor Author

lgalis commented Aug 16, 2016

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Aug 16, 2016
@chessbyte chessbyte changed the title [WIP] Delete configuration provider when selected from tree does not work Delete configuration provider when selected from tree does not work Aug 16, 2016
@mzazrivec mzazrivec added this to the Sprint 45 Ending Aug 22, 2016 milestone Aug 18, 2016
@mzazrivec mzazrivec merged commit e1742b5 into ManageIQ:master Aug 18, 2016
@lgalis
Copy link
Contributor Author

lgalis commented Aug 18, 2016 •
edited

The BZ was cloned to the 5.6 zstream - changing teh label to darga/yes
@miq-bot remove_label darga/no

@miq-bot miq-bot removed the darga/no label Aug 18, 2016
@lgalis
Copy link
Contributor Author

lgalis commented Aug 18, 2016

@miq-bot add_label darga/yes

@lgalis lgalis deleted the delete_config_provider_from_tree_fails branch August 18, 2016 17:26
@mzazrivec
Copy link
Contributor

@lgalis is bz 1368168 really the correct bz for darga here? It doesn't seem related (not at first sight anyway).

chessbyte pushed a commit that referenced this pull request Aug 23, 2016
@mzazrivec @chessbyte
Merge pull request #10497 from lgalis/delete_config_provider_from_tre…
9efb1e9 
…e_fails

Delete configuration provider when selected from tree does not work
(cherry picked from commit e1742b5)
@chessbyte
Copy link
Member

Darga backport details:

commit 9efb1e9e1df6a7d34c36fac9ffe52f3e81c774ca
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Aug 18 11:48:53 2016 +0200

    Merge pull request #10497 from lgalis/delete_config_provider_from_tree_fails

    Delete configuration provider when selected from tree does not work
    (cherry picked from commit e1742b560d0be516c9a1480f079d9ece0f3e9b1a)

@chessbyte
Copy link
Member

@dclarizio @lgalis This PR uses stub_user which is not in Darga. Thus, tests are failing. See https://travis-ci.org/ManageIQ/manageiq/builds/154630140

@lgalis lgalis mentioned this pull request Aug 24, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dclarizio dclarizio

Labels
bug darga/backported ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lgalis @miq-bot @mzazrivec @chessbyte @dclarizio