-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patternfly upgraded to v3.9.0 #10509
Conversation
Looks good |
@miq-bot add_label ui |
@skateman seems like there was a change in patternfly where selectpicker doesn't set The vmdb failure looks rather unrelated otoh.. |
I'm looking at the test failures but... EDIT: The bower resolutions problem - hoping to fix that by something like bower/bower#2345 (but not sure if bower is still alive enough for this to get in..) The |
😢 😢 😢 😢 😢 😢 😢 😢 😢 😢 😢 😢 😢 😢 😢 😢 |
Updated the tests to reflect the new selectpicker structure (and cleaned up those The toolbar is still broken though.. |
.. to track the problems ..
|
Let's wait for the angular toolbar to be merged, then we should upgrade directly to 3.9.0. @himdel @epwinchell ? |
@skateman I totally agree. |
Sure, no rush :) might be easier to fix the view toolbar after. |
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
@skateman you can replace that last commit by an update of |
@himdel yup, and also the pf version to 3.9.0 :) |
d371427
to
7e7dfcc
Compare
Found one more issue (maybe pf-3.9?) .. hovering over the active menu item (secondary or tertiary) shows a black top border (Added to the list) |
This also happens on the patternfly 3.9.0 test pages, cc @jeff-phillips-18 patternfly/patternfly#442 |
@skateman nice, that's probably everything then.. Should I merge, or do we wait for 3.10 (2 days I guess?)? EDIT: guessing we don't want to wait, it's a minor issue |
@epwinchell can you also check this? LGTM |
cb71542
to
9cbe9b6
Compare
this is needed because patternfly 3.8 changes the selectpicker structure.. Previously it would hide the <select> using .bs-select-hidden, and append the new button right after. Now, it moves the <select> inside that button, and doesn't add any extra class. Also, elem[0][1] is painful to read, use descriptive selectors and variables. (cherry picked from commit 51bafeb246602e98ac6c3effec1b184bb9471b75)
we keep the toolbar wrapping margin fix, and remove the resulting double margin by forcing toolbar-pf-actions' bottom margin to 0 .. and remove duplicate css introduced in ManageIQ#9753
9cbe9b6
to
76f4ff2
Compare
@epwinchell @himdel pin/unpin buttons fixed |
@miq-bot remove_label wip |
FYI, we want the pin icon to be used. Currently PatternFly has the arrows rather than the pin - so we should change that once the upgrade is complete |
To change to pins for the collapse button in the header you can override with: .secondary-collapse-toggle-pf { |
Checked commits skateman/manageiq@ad4633a~...b82024c with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 app/views/layouts/_content.html.haml |
👍 |
Not seeing any more UI breakage, merging.. @skateman We should however upgrade to 3.10 soon because of that active menu item bug :) |
@jeff-phillips-18 @serenamarie125 any idea when that pin change will get into patternfly? |
@himdel I will talk to Leslie this week. There was some reluctance to taking this, but based on the user feedback that I've been getting from CloudForms customers, I'm still suggesting we go with it. I'll get back to you |
Now we're back with the proper gem version!
@himdel @epwinchell please review