miqUncompressedId - fix [sprintf] expecting number but found string

[himdel]

@chrisarcand reported seeing a [sprintf] expecting number but found string error..

sprintf doesn't typecast, and splitting a string yields two strings.. fixing to expect a string.

(alternatively we could convert it to a number but might get weird off-by-ones on 32 bit systems that way..)

---

Actually, the typecasting bit is a bit more complicated, it can treat a string as a number, as long as the native isNaN returns false for it..

[himdel]

@chrisarcand hope this fixes the problem...

Should it not, could you please do.. (in the browser console)

var bak = window.sprintf;
window.sprintf = function() { console.log(arguments); return bak.apply(window, arguments); };

and post the last one before it blows up?

[chrisarcand]

It looks like this fixed one (or a few) of the error messages for sure!

I still get one more, clicking around:

Looks like your tests might be failing due to an unrelated issue, might want to give it a rebase and a kick.

[himdel]

Great, thanks! :) Rebased..

[chrisarcand]

[himdel]

@chrisarcand that's not really related to the other issue, so I'd prefer to fix that in a separate PR.. But yup, noted :)

[chrisarcand]

ok! LGTM from me, then 👍

[miq-bot]

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

[miq-bot]

Checked commits https://github.com/himdel/manageiq/compare/d70ef268da93c0c3bf8cb00125d725b0f99d56dc~...37297cf38c84110bfc65e2ee15bb0b6ca2421975 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
0 files checked, 0 offenses detected
Everything looks good. 👍

[dclarizio]

Based on @chrisarcand's review, merging this.