Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DARGA] Bump ovirt gem dependency to 0.12.1 #10769

Merged
merged 1 commit into from Aug 30, 2016
Merged

Conversation

matobet
Copy link
Contributor

@matobet matobet commented Aug 25, 2016

No description provided.

@miq-bot
Copy link
Member

miq-bot commented Aug 25, 2016

Checked commit matobet@53b059c with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. 👍

@chessbyte chessbyte changed the title Bump ovirt gem dependency to 0.12.1 [DARGA] Bump ovirt gem dependency to 0.12.1 Aug 25, 2016
@chessbyte chessbyte self-assigned this Aug 25, 2016
@matobet
Copy link
Contributor Author

matobet commented Aug 30, 2016

@chessbyte Is some action required from my side before this can be merged? A label or such?

@chessbyte
Copy link
Member

Just returning from vacation - give me a bit to review version change to rest-client with Providers team. /cc @blomquisg @abellotti

@abellotti
Copy link
Member

should be ok to bump to 2.0.0 for rest-client, gems/pending/Gemfile already references it.

@blomquisg
Copy link
Member

@chessbyte good to go from providers side

@chessbyte chessbyte merged commit e0d00b7 into ManageIQ:darga Aug 30, 2016
@chessbyte chessbyte added this to the Sprint 46 Ending Sep 12, 2016 milestone Aug 30, 2016
@chessbyte
Copy link
Member

@matobet was there a PR against Master? Did it fix a Bugzilla or GitHub issue? Can you provide all this info.

@matobet
Copy link
Contributor Author

matobet commented Aug 31, 2016

@chessbyte there was a different commit against master e1009e0 that bumps it to 0.13.0 along with other changes. We needed only 0.12.1 for darga and it actually includes multiple fixes from me, @jelkosz @borod108 and @masayag.

@chessbyte If you wish we can gather all related bugzillas here.

@simaishi
Copy link
Contributor

simaishi commented Sep 1, 2016

@matobet Can you provide 1 BZ that requires 0.12.1? Bumping to 0.12.1 changes required nokogiri version to 1.6.8 and I'd need a BZ for tracking purpose.. Thanks.

@simaishi
Copy link
Contributor

simaishi commented Sep 9, 2016

@matobet @jelkosz @borod108 @masayag - please provide a Darga BZ.

@matobet
Copy link
Contributor Author

matobet commented Sep 9, 2016

@simaishi
Copy link
Contributor

simaishi commented Sep 9, 2016

Perfect, thanks @matobet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants