Vm provision handle ems_ref properly #11285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During vm clone from template we need to make sure that cloned vm uses properly built ems_ref.
jhernand
approved these changes
Sep 15, 2016
|
This PR fixes: |
|
@miq-bot assign @blomquisg |
|
Checked commit pkliczewski@8d4be21 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
cc @bdunne |
|
Looks good to me. |
|
@miq-bot add_label darga/yes |
|
@pkliczewski Please add a link to the BZ in the commit message. @bdunne Please review. |
|
👍 LGTM. Please restart the affected tests, the unrelated failure has been corrected on master. |
chessbyte
pushed a commit
that referenced
this pull request
Sep 19, 2016
Vm provision handle ems_ref properly (cherry picked from commit 8f42493)
|
Darga Backport details: $ git cherry-pick -x -m 1 8f42493
[darga 7a3e697] Merge pull request #11285 from pkliczewski/vm_provision
Author: Greg McCullough <gmccullo@redhat.com>
Date: Thu Sep 15 16:15:08 2016 -0400
1 file changed, 1 insertion(+), 1 deletion(-)
$ git log
commit 7a3e697d7a98d7747e7de75650cbbad4b29bd50f
Author: Greg McCullough <gmccullo@redhat.com>
Date: Thu Sep 15 16:15:08 2016 -0400
Merge pull request #11285 from pkliczewski/vm_provision
Vm provision handle ems_ref properly
(cherry picked from commit 8f42493f86386121a5286ef49c30de0ee713e214) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During vm clone we did not parse ems_ref propely.