Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of applied chargeback rate names as field in chargeback reports #11523

Merged
merged 1 commit into from Oct 3, 2016

Conversation

zeari
Copy link

@zeari zeari commented Sep 26, 2016

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1369442
Add applied chargeback rate names to chargeback report
screencapture-localhost-3000-report-explorer-1474912813629

@gtanzillo @enoodle Please review
cc @simon3z

@zeari zeari changed the title Add list of chargeback rate names as field in chargeback reports Add list of applied chargeback rate names as field in chargeback reports Sep 26, 2016
@zeari
Copy link
Author

zeari commented Sep 27, 2016

@miq-bot add_label providers/containers

@miq-bot
Copy link
Member

miq-bot commented Sep 29, 2016

Checked commit zeari@dfcf619 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
4 files checked, 2 offenses detected

app/controllers/report_controller/reports/editor.rb

app/models/chargeback.rb

@gtanzillo gtanzillo added this to the Sprint 47 Ending Oct 3, 2016 milestone Oct 3, 2016
@gtanzillo
Copy link
Member

👍 LGTM

@gtanzillo gtanzillo merged commit b06ad9c into ManageIQ:master Oct 3, 2016
chessbyte pushed a commit that referenced this pull request Oct 3, 2016
Add list of applied chargeback rate names as field in chargeback reports
(cherry picked from commit b06ad9c)
@chessbyte
Copy link
Member

Euwe Backport details:

$ git log
ommit 96ec8eee944accebe6d5759b2c913bd48c5953b1
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Mon Oct 3 08:11:21 2016 -0400

    Merge pull request #11523 from zeari/chargeback_rate_name

    Add list of applied chargeback rate names as field in chargeback reports
    (cherry picked from commit b06ad9ced9b706446f1290f8e45f96f9ee85c670)

@zeari zeari deleted the chargeback_rate_name branch August 24, 2017 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants