Images for pluggable provider domains in Automate Explorer #11618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the top_level_namespace, use the appropriate vendor icon Added a new manageiq png
|
@h-kataria @epwinchell @tinaafitz |
|
Checked commit mkanoor@b790b36 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@mkanoor Looks great! |
|
@mkanoor Looks good |
|
@miq-bot unassign @epwinchell |
|
@epwinchell unrecognized command 'unassign', ignoring... Accepted commands are: add_label, remove_label, rm_label, assign, set_milestone |
|
looks good |
|
@mkanoor @h-kataria please label |
chessbyte
pushed a commit
that referenced
this pull request
Oct 5, 2016
Images for pluggable provider domains in Automate Explorer (cherry picked from commit 6868d8f)
|
Euwe Backport details: $ git log
commit c98ea7bf6cdf6cd0de2a4b99577d6eeb9728330b
Author: Harpreet Kataria <hkataria@redhat.com>
Date: Mon Oct 3 18:27:06 2016 -0400
Merge pull request #11618 from mkanoor/domain_icons
Images for pluggable provider domains in Automate Explorer
(cherry picked from commit 6868d8f6e91d144066f535c6b8773400e05fe2fa) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the top_level_namespace, use the appropriate vendor icon
Added a new manageiq png
https://www.pivotaltracker.com/n/projects/1613499/stories/131438349
Before
After
Based on PR:
#11368