Extract getting key and fields to method in chargeback #11645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
force-pushed
the
extract_key_and_fields_to_method
branch
from
596bf7a
to
7caf205
Compare
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
lpichler
force-pushed
the
extract_key_and_fields_to_method
branch
from
7caf205
to
406fd9a
Compare
gtanzillo
suggested changes
Oct 3, 2016
| def self.date_fields(metric_rollup_record, interval, tz) | ||
| start_ts, end_ts, display_range = get_time_range(metric_rollup_record, interval, tz) | ||
|
|
||
| {"start_date" => start_ts, "end_date" => end_ts, "display_range" => display_range, "interval_name" => interval, |
There was a problem hiding this comment.
Small nit, but I think that would be more readable if each k/v pair was on a separate line.
(cherry picked from commit bcfb5577bffcd1895a9a5ae124d1080209c9f584)
lpichler
force-pushed
the
extract_key_and_fields_to_method
branch
from
406fd9a
to
577e69a
Compare
|
Checked commit lpichler@577e69a with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
gtanzillo
approved these changes
Oct 4, 2016
chessbyte
pushed a commit
that referenced
this pull request
Oct 5, 2016
Extract getting key and fields to method in chargeback (cherry picked from commit becd152)
|
Euwe Backport details: $ git log
commit 2e90dfad39bffdc8a0b738739177a447a1d7ebda
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date: Tue Oct 4 08:54:30 2016 -0400
Merge pull request #11645 from lpichler/extract_key_and_fields_to_method
Extract getting key and fields to method in chargeback
(cherry picked from commit becd152459bb2914feeb755a7bde981108b54672) |
lpichler
pushed a commit
to lpichler/manageiq
that referenced
this pull request
Oct 21, 2016
…s_to_method Extract getting key and fields to method in chargeback (cherry picked from commit becd152)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
method 'key_and_fields' will not be used for each MetricRollup record but for groups records according to interval(weekly, hourly, monthly)
@miq-bot add_label chargeback, refactoring
@miq-bot assign @gtanzillo