Conversion of Middleware Provider form to Angular #11673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commits AparnaKarve/manageiq@8145726~...0369aff with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 app/views/ems_middleware/_form.html.haml app/views/ems_middleware/edit.html.haml
app/views/ems_middleware/new.html.haml
|
|
@pilhuhn Can you give this a try? Thanks. |
|
Awesome @AparnaKarve works like a charm |
|
@miq-bot assign @dclarizio |
chessbyte
pushed a commit
that referenced
this pull request
Oct 5, 2016
Conversion of Middleware Provider form to Angular (cherry picked from commit 6d556d5)
|
Euwe Backport details: $ git log
commit 4e5a5609c757e1f4c28163fb4de4efb2a010d28b
Author: Dan Clarizio <dclarizi@redhat.com>
Date: Tue Oct 4 09:28:21 2016 -0700
Merge pull request #11673 from AparnaKarve/middleware_to_angular
Conversion of Middleware Provider form to Angular
(cherry picked from commit 6d556d5396380816a83ffc8e9e8343ea325fbc11) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the Middleware Provider form to Angular and leverage the validation directives that are currently used by the other providers.
PR includes specs for
ems_middlewarerouting, controller actions likecreateandupdateand also jasmine specs.Fixes #9789
Fixes #11296