Fix QE JS helpers' debounce not preserving this #11707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cceaa3c.
previously, we were always providing an empty object as `this` in the debounced function Now, assuming `new_debounced_func` is called with the right `this`, it's passed to `debounced_func`, then `orig_debounce` preserves that so it gets passed to `new_func`, which means that with this change, it gets propagated to `func` too.
Merged
|
Checked commits https://github.com/himdel/manageiq/compare/841b010966e16d6cf09c1b454de0ab7b5cdee176~...cc3bb44beaeefe0b9f45210fff6562b418311a0c with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
Tested fix in UI, looks good. |
chessbyte
pushed a commit
that referenced
this pull request
Oct 5, 2016
Fix QE JS helpers' debounce not preserving this (cherry picked from commit f1b91c1)
|
Euwe Backport details: $ git log
commit 9d9ec75abeefa5628b2a0ad7b6b8a2978d1a551f
Author: Dan Clarizio <dclarizi@redhat.com>
Date: Wed Oct 5 08:54:07 2016 -0700
Merge pull request #11707 from himdel/fix-qe
Fix QE JS helpers' debounce not preserving this
(cherry picked from commit f1b91c10a47375d149f73575934427d07f2b1146) |
|
Backported to Darga via #11911 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #11390, we introduced helper functions to make the QE's life easier. But there was a bug where the modified
_.debouncewould not preserve the value ofthisall the way to the callback.It got disabled in #11697, so this PR is re-enabling the functionality, and fixing the
thisbug..Now, assuming
new_debounced_funcis called with the rightthis, it's passed todebounced_func, thenorig_debouncepreserves that so it gets passed tonew_func, which means that with this change, it gets propagated tofunctoo.Re-added
euwe/yesto #11390, adding here as well..Cc @martinpovolny, @h-kataria