Time threshold for real time performance has to be a required field #11717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit mzazrivec@edc49c4 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@h-kataria is this ready to go? |
|
looks good, tested in UI |
chessbyte
pushed a commit
that referenced
this pull request
Oct 22, 2016
…mance_is_required Time threshold for real time performance has to be a required field (cherry picked from commit 210b52d) https://bugzilla.redhat.com/show_bug.cgi?id=1379078
|
Euwe Backport details: $ git log -1
commit b9ef9cea76efe2d2c68b3f05b29f9d4c7f42070d
Author: Harpreet Kataria <hkataria@redhat.com>
Date: Fri Oct 21 23:38:36 2016 -0400
Merge pull request #11717 from mzazrivec/time_threshold_for_rt_performance_is_required
Time threshold for real time performance has to be a required field
(cherry picked from commit 210b52d0a31d17cf10aa9d14d4e5f3110f7584e9)
https://bugzilla.redhat.com/show_bug.cgi?id=1379078 |
chessbyte
pushed a commit
that referenced
this pull request
Nov 3, 2016
…mance_is_required Time threshold for real time performance has to be a required field (cherry picked from commit 210b52d) https://bugzilla.redhat.com/show_bug.cgi?id=1389025
|
Darga Backport details: $ git log -1
commit b15bfe7e68c9e57396d35ba62d8c2520bc53da07
Author: Harpreet Kataria <hkataria@redhat.com>
Date: Fri Oct 21 23:38:36 2016 -0400
Merge pull request #11717 from mzazrivec/time_threshold_for_rt_performance_is_required
Time threshold for real time performance has to be a required field
(cherry picked from commit 210b52d0a31d17cf10aa9d14d4e5f3110f7584e9)
https://bugzilla.redhat.com/show_bug.cgi?id=1389025 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce:
Before, the form would allow creation of an alert with the time threshold set to nothing. With
this fix in place, the form create would return a flash message.
https://bugzilla.redhat.com/show_bug.cgi?id=1379078