Fix Parent EMS Cloud Title on Storage Pages #11726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryk55
force-pushed
the
Fix_Parent_Ems_Cloud_Title_on_Storage_Mgr_Pages
branch
from
f4298c7
to
17a9428
Compare
|
@dclarizio @h-kataria changed to use ui_lookup to obtain the title string. |
Six pages added or modified recently for Cloud Storage and Storage Manager pages mis-titled the link to the Cloud Manager. It defaulted to "Parent ems cloud" and should be "Parent Cloud Provider".
Based on (out-of-band) review comments from @h-kataria, the title string was changed to that returned from a call to ui_lookup for the CloudManager model.
jerryk55
force-pushed
the
Fix_Parent_Ems_Cloud_Title_on_Storage_Mgr_Pages
branch
from
17a9428
to
79a6ddb
Compare
|
@dclarizio @h-kataria fixed to now do the ui_lookup on the model instead of using a table lookup based on the parent object. The parent object results in a string that is too long - "Parent Cloud Provider (Openstack)". Using the model "ManageIQ::Providers::CloudManager" results in the string "Parent Cloud Provider". This is ready to rock and roll. |
|
Checked commits jerryk55/manageiq@38a4c93~...79a6ddb with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
looks good |
chessbyte
pushed a commit
that referenced
this pull request
Oct 13, 2016
…_Storage_Mgr_Pages Fix Parent EMS Cloud Title on Storage Pages (cherry picked from commit 2ebb35f)
|
Euwe Backport details: $ git log
commit 53e1abad1c3e74578022d961c2f5a79fc18e6352
Author: Harpreet Kataria <hkataria@redhat.com>
Date: Thu Oct 6 13:01:34 2016 -0400
Merge pull request #11726 from jerryk55/Fix_Parent_Ems_Cloud_Title_on_Storage_Mgr_Pages
Fix Parent EMS Cloud Title on Storage Pages
(cherry picked from commit 2ebb35fb7aba59fb11e96a3d1b9b33c44782d449) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Six pages added or modified recently for Cloud Storage and Storage Manager pages
mis-titled the link to the Cloud Manager. It defaulted to "Parent ems cloud" and
should be "Parent Cloud Provider".
Here is an image of the relevant relationship field for a Cloud Object Store Object.
The pages changed were:
@h-kataria @dclarizio @roliveri please review and merge. Thanks.