Timeline: Modify popover logic and fix filterbar layout #11763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit dgutride@a8f23c3 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
dgutride
force-pushed
the
timeline-layout-fixes
branch
from
bc1accd
to
a8f23c3
Compare
|
@chessbyte - @dclarizio - is there a chance this will be taken in? It's a browser compatibility bug and not an enhancement. |
|
looks good |
chessbyte
pushed a commit
that referenced
this pull request
Oct 13, 2016
Timeline: Modify popover logic and fix filterbar layout (cherry picked from commit 5cdacea)
|
Euwe Backport details: $ git log
commit a843b09ad08ac027b85e9511a27d37f48245b430
Author: Harpreet Kataria <hkataria@redhat.com>
Date: Tue Oct 11 09:19:45 2016 -0400
Merge pull request #11763 from dgutride/timeline-layout-fixes
Timeline: Modify popover logic and fix filterbar layout
(cherry picked from commit 5cdacea57d310d25df4ee172dd93663ea977adaf) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feedback from the initial review of the timeline revealed the apply button location was broken and event clicking in firefox was also broken. This review fixes those concerns.
@h-kataria , @serenamarie125 , @dclarizio
Steps for Testing/QA [Optional]
These are layout changes only - no functional changes were introduced