Enhance Generic Object methods. #11876
Conversation
| GenericObject.create!({:generic_object_definition => self}.merge(options)) | ||
| end | ||
|
|
||
| def find_objects(options) |
There was a problem hiding this comment.
@lfu can you add comments here what fields are searchable, and possibly what are expected to be searchable in the future?
| json_options = dup.extract!(*property_attributes.keys) | ||
|
|
||
| unless dup.empty? | ||
| err_msg = _("Attributes [%{attrs}] do not exist") % {:attrs => dup.keys.join(", ")} |
There was a problem hiding this comment.
The error message may be misleading since you only support property_attributes for now. When a search for associations for example, the field may exist but simply not searchable.
lfu
force-pushed
the
enhance_go_methods
branch
2 times, most recently
from
a5d1e2c
to
14c17ea
Compare
| # find_objects(:vms => [23, 26]) | ||
| # | ||
| def find_objects(options) | ||
| dup = options.stringify_keys!.dup |
There was a problem hiding this comment.
we don't want to modify options, so dup first and then stringify_keys.
| json_options = dup.extract!(*(property_attributes.keys + property_associations.keys)) | ||
|
|
||
| unless dup.empty? | ||
| err_msg = _("[%{attrs}]: not defined for Generic Object of %{name}") % {:attrs => dup.keys.join(", "), |
There was a problem hiding this comment.
consider the wording not searchable instead of not defined, for example a method name might be defined but not searchable.
| @g1.vms = [vm[0], vm[1], vm[2]] | ||
| @g1.save! | ||
|
|
||
| @options = {:vms => [vm[0].id, vm[1].id]} |
There was a problem hiding this comment.
I like jsonb that can do this partial matching search 👍
lfu
force-pushed
the
enhance_go_methods
branch
2 times, most recently
from
ba91a72
to
cb20bae
Compare
| # find_objects(:vms => [23, 26]) | ||
| # | ||
| def find_objects(options) | ||
| dup = options.dup.stringify_keys! |
There was a problem hiding this comment.
sorry @lfu. dup = options.stringify_keys should be sufficient.
| # To query based on GenericObject AR attributes and property attributes | ||
| # find_objects(:name => "TestLoadBalancer", :uid => '0001', :prop_attr_1 => 10, :prop_attr_2 => true) | ||
| # | ||
| # To query based on property associations |
There was a problem hiding this comment.
To query based on property associations. The array does not need to be a complete list, but must contain only AR ids.
lfu
force-pushed
the
enhance_go_methods
branch
from
cb20bae
to
31045ec
Compare
…ram_2 => 14, :param_2_type => "Fixnum"}
lfu
force-pushed
the
enhance_go_methods
branch
from
31045ec
to
fde84cb
Compare
|
Checked commits lfu/manageiq@048f104~...fde84cb with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 app/models/generic_object_definition.rb
spec/models/generic_object_spec.rb
|
| args.each_with_index { |item, idx| attrs["param_#{idx + 1}".to_sym] = item } | ||
| args.each_with_index do |item, idx| | ||
| attrs["param_#{idx + 1}".to_sym] = item | ||
| attrs["param_#{idx + 1}_type".to_sym] = item.class.name |
There was a problem hiding this comment.
For container Hash and Array, we can't know the type of each element. This is a limitation but I don't think we need to address it.
There was a problem hiding this comment.
Agreed, there are some limitations to calling methods on Generic Objects.
|
LGTM. Thanks. |
|
@gmcculloug Anything to update? |
|
Looks good. Thanks! |
Enhance Generic Object methods. (cherry picked from commit fd0a6bf)
|
Euwe Backport details: $ git log -1
commit 3e851efb17b9aa03b4869e53f7fad0529bcf1a3d
Author: Greg McCullough <gmccullo@redhat.com>
Date: Fri Oct 21 18:15:09 2016 -0400
Merge pull request #11876 from lfu/enhance_go_methods
Enhance Generic Object methods.
(cherry picked from commit fd0a6bfd3ff55d8905c8ea8155607615a6a7286f) |
Add GenericObjectDefinition#find_objects method.
Expose more GenericObjectDefinition methods into automate.
cc @gmcculloug @bzwei @mkanoor