-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the issue that alerts don't send SNMP traps. #11988
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@lfu Please review failing test. |
Private methods can only be called without an explicit receiver. https://bugzilla.redhat.com/show_bug.cgi?id=1381287
f0774e4
to
e3850ee
Compare
Checked commits lfu/manageiq@e42a531~...e3850ee with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
@simaishi Please clone https://bugzilla.redhat.com/show_bug.cgi?id=1381287 for Euwe |
chessbyte
added a commit
that referenced
this pull request
Oct 19, 2016
Fix the issue that alerts don't send SNMP traps. (cherry picked from commit f62e14e) https://bugzilla.redhat.com/show_bug.cgi?id=1381287
Euwe Backport details: $ git log -1
commit 5c08fab4970337d274b35a49bbb64956efa42036
Author: Oleg Barenboim <chessbyte@gmail.com>
Date: Tue Oct 18 06:07:45 2016 -0500
Merge pull request #11988 from lfu/snmp_trap_1381287
Fix the issue that alerts don't send SNMP traps.
(cherry picked from commit f62e14ec595b242db2a53cb910b6708049c1bb36)
https://bugzilla.redhat.com/show_bug.cgi?id=1381287 |
chessbyte
added a commit
that referenced
this pull request
Nov 3, 2016
Fix the issue that alerts don't send SNMP traps. (cherry picked from commit f62e14e) https://bugzilla.redhat.com/show_bug.cgi?id=1386792
Darga Backport details: $ git log -1
commit fba0d97578dafa422bca8000ea40c188ff6a11ad
Author: Oleg Barenboim <chessbyte@gmail.com>
Date: Tue Oct 18 06:07:45 2016 -0500
Merge pull request #11988 from lfu/snmp_trap_1381287
Fix the issue that alerts don't send SNMP traps.
(cherry picked from commit f62e14ec595b242db2a53cb910b6708049c1bb36)
https://bugzilla.redhat.com/show_bug.cgi?id=1386792 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private methods can only be called without an explicit receiver.
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1381287
cc @gmcculloug