Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue that alerts don't send SNMP traps. #11988

Merged
merged 2 commits into from
Oct 18, 2016

Conversation

lfu
Copy link
Member

@lfu lfu commented Oct 17, 2016

Private methods can only be called without an explicit receiver.

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1381287

cc @gmcculloug

@gmcculloug
Copy link
Member

@lfu Please review failing test.

@miq-bot
Copy link
Member

miq-bot commented Oct 17, 2016

Checked commits lfu/manageiq@e42a531~...e3850ee with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
2 files checked, 0 offenses detected
Everything looks good. 🏆

@chessbyte chessbyte assigned chessbyte and unassigned gmcculloug Oct 18, 2016
@chessbyte chessbyte merged commit f62e14e into ManageIQ:master Oct 18, 2016
@chessbyte chessbyte added this to the Sprint 48 Ending Oct 24, 2016 milestone Oct 18, 2016
@chessbyte
Copy link
Member

chessbyte added a commit that referenced this pull request Oct 19, 2016
Fix the issue that alerts don't send SNMP traps.
(cherry picked from commit f62e14e)

https://bugzilla.redhat.com/show_bug.cgi?id=1381287
@chessbyte
Copy link
Member

Euwe Backport details:

$ git log -1
commit 5c08fab4970337d274b35a49bbb64956efa42036
Author: Oleg Barenboim <chessbyte@gmail.com>
Date:   Tue Oct 18 06:07:45 2016 -0500

    Merge pull request #11988 from lfu/snmp_trap_1381287

    Fix the issue that alerts don't send SNMP traps.
    (cherry picked from commit f62e14ec595b242db2a53cb910b6708049c1bb36)

    https://bugzilla.redhat.com/show_bug.cgi?id=1381287

@lfu
Copy link
Member Author

lfu commented Oct 19, 2016

@simaishi Also need a BZ for Darga.
@miq-bot add_label darga/yes

@simaishi
Copy link
Contributor

chessbyte added a commit that referenced this pull request Nov 3, 2016
Fix the issue that alerts don't send SNMP traps.
(cherry picked from commit f62e14e)

https://bugzilla.redhat.com/show_bug.cgi?id=1386792
@chessbyte
Copy link
Member

Darga Backport details:

$ git log -1
commit fba0d97578dafa422bca8000ea40c188ff6a11ad
Author: Oleg Barenboim <chessbyte@gmail.com>
Date:   Tue Oct 18 06:07:45 2016 -0500

    Merge pull request #11988 from lfu/snmp_trap_1381287

    Fix the issue that alerts don't send SNMP traps.
    (cherry picked from commit f62e14ec595b242db2a53cb910b6708049c1bb36)

    https://bugzilla.redhat.com/show_bug.cgi?id=1386792

@lfu lfu deleted the snmp_trap_1381287 branch March 2, 2017 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants