Add the provider region to the replication subscription array data #11990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
requested changes
Oct 17, 2016
| remote_ws_address = region ? region.remote_ws_address : '' | ||
| h.merge!(:auth_key_configured => region && region.auth_key_configured? ? true : false, :remote_ws_address => remote_ws_address) | ||
| region = MiqRegion.find_by(:region => h[:provider_region]) | ||
| if region |
There was a problem hiding this comment.
You could get rid of this conditional with:
h.merge!(:auth_key_configured => region.try(:auth_key_configured?), :remote_ws_address => region.try(:remote_ws_address).to_s)There was a problem hiding this comment.
I'm not sure if we specifically need false if there is no auth key @lgalis ?
There was a problem hiding this comment.
if we need false we can add a !!
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
Not having this data was preventing all of the central administration authentication feature from working.
carbonin
force-pushed
the
fix_central_admin_authentication_ui
branch
from
a1568e6
to
ee0f8f5
Compare
|
Checked commit carbonin@ee0f8f5 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 app/controllers/ops_controller/settings/common.rb
|
bdunne
approved these changes
Oct 17, 2016
chessbyte
added a commit
that referenced
this pull request
Oct 19, 2016
…ion_ui Add the provider region to the replication subscription array data (cherry picked from commit 3e90d92) https://bugzilla.redhat.com/show_bug.cgi?id=1386344
|
Euwe Backport details: $ git log -1
commit d86726d940ed721ff8dfef0be2694027e73e359d
Author: Oleg Barenboim <chessbyte@gmail.com>
Date: Tue Oct 18 05:50:00 2016 -0500
Merge pull request #11990 from carbonin/fix_central_admin_authentication_ui
Add the provider region to the replication subscription array data
(cherry picked from commit 3e90d92fa6e03edc5803a02fcd8ce33633f4b59f)
https://bugzilla.redhat.com/show_bug.cgi?id=1386344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not having this data was preventing any of the central administration authentication UI feature from working.
@lgalis please review.
https://bugzilla.redhat.com/show_bug.cgi?id=1385821