Fixed class name and key name in add/edit of user role code #11999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
changed the title
Fixed inssue introduced in sha: 93f3f5e in ManageIQ#11466
h-kataria
force-pushed
the
user_role_add_fix
branch
from
634d282
to
cdc9419
Compare
h-kataria
changed the title
|
Checked commit h-kataria@cdc9419 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@martinpovolny Tested in UI, fixes the issue 👍. Thank you, @h-kataria 😊 |
|
Need to backport to EUWE to fix https://bugzilla.redhat.com/show_bug.cgi?id=1390969 cc @chessbyte |
chessbyte
pushed a commit
that referenced
this pull request
Nov 7, 2016
Fixed class name and key name in add/edit of user role code (cherry picked from commit 17bc43f) https://bugzilla.redhat.com/show_bug.cgi?id=1390969
|
Euwe Backport details: $ git log -1
commit 02b4259290fc3b92799fbe611b0688c699eea583
Author: Martin Povolny <mpovolny@redhat.com>
Date: Tue Oct 18 09:57:16 2016 +0200
Merge pull request #11999 from h-kataria/user_role_add_fix
Fixed class name and key name in add/edit of user role code
(cherry picked from commit 17bc43fcb6893b14737a5a63f7fddbdf404ed295)
https://bugzilla.redhat.com/show_bug.cgi?id=1390969 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed inssue introduced in sha: 93f3f5e in #11466
@martinpovolny @romanblanco please review. This fixes an issue introduced in #11466 that is preventing from adding User Roles in UI.