Add .class_from_request_data for inverse lookup of model from request_type #12007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abellotti Please review |
abellotti
reviewed
Oct 17, 2016
|
|
||
| delegate :deny, :reason, :stamped_on, :to => :first_approval | ||
| delegate :userid, :to => :requester, :prefix => true | ||
| delegate :request_task_class, :request_types, :task_description, :to => :class | ||
|
|
||
| def self.class_from_request_data(data) | ||
| request_type = data[:request_type].to_sym |
There was a problem hiding this comment.
:request_type could be missing and this would blow up. Could we have a raise("Missing request_type") before this statement in case it's not specified. The API could rescue from calling this method and return the exception to the caller.
bdunne
force-pushed
the
class_from_request_data
branch
from
6cc42a0
to
425ba46
Compare
|
@bdunne I'd like to merge this, but could you take care of Mr. Rubocop. Thanks. |
bdunne
force-pushed
the
class_from_request_data
branch
from
425ba46
to
010572a
Compare
|
Checked commit bdunne@010572a with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
Thanks @bdunne for the update. Will merge when 🍏 |
chessbyte
pushed a commit
that referenced
this pull request
Oct 21, 2016
Add .class_from_request_data for inverse lookup of model from request_type (cherry picked from commit 440e856)
|
Euwe Backport details: $ git log -1
commit 70076998b0b6388f5718a3a4d15b7d78ca3250d8
Author: Alberto Bellotti <abellotti@users.noreply.github.com>
Date: Wed Oct 19 11:07:49 2016 -0400
Merge pull request #12007 from bdunne/class_from_request_data
Add .class_from_request_data for inverse lookup of model from request_type
(cherry picked from commit 440e856a6f9bcc6be50d7f93d7938492fe6bf267) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ease reverse lookup of MiqRequest subclass from the request_type for the API. With the correct subclass the task description and other defaulted attributes will be properly set.