Ansible Tower Job Template shows the previously selected record on return #12066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq_bot add_label wip |
|
@miq-bot add_label ui, bug |
|
@miq-bot add_label wip |
lgalis
changed the title
lgalis
force-pushed
the
ansible_job_template_display_on_return_to_tab
branch
from
013468a
to
98380ee
Compare
lgalis
changed the title
|
@miq-bot remove_label wip |
chessbyte
reviewed
Oct 20, 2016
| before do | ||
| right_cell_text = nil | ||
| login_as user_with_feature(%w(providers_accord configured_systems_filter_accord configuration_scripts_accord)) | ||
| controller.instance_variable_set(:@right_cell_text, right_cell_text) |
There was a problem hiding this comment.
why not the simpler: controller.instance_variable_set(:@right_cell_text, nil)?
lgalis
force-pushed
the
ansible_job_template_display_on_return_to_tab
branch
from
98380ee
to
dc7c4aa
Compare
lgalis
force-pushed
the
ansible_job_template_display_on_return_to_tab
branch
from
dc7c4aa
to
5059c74
Compare
|
Checked commits lgalis/manageiq@43a54c3~...5059c74 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
chessbyte
pushed a commit
that referenced
this pull request
Oct 21, 2016
…_return_to_tab Ansible Tower Job Template shows the previously selected record on return (cherry picked from commit 0e7133d) https://bugzilla.redhat.com/show_bug.cgi?id=1387708
|
Euwe Backport details: $ git log -1
commit d8075246e2da0b9f2c9d9b9ec7ae3000137058c1
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date: Fri Oct 21 13:34:15 2016 +0200
Merge pull request #12066 from lgalis/ansible_job_template_display_on_return_to_tab
Ansible Tower Job Template shows the previously selected record on return
(cherry picked from commit 0e7133db403b7d9273ba42f1431ca11829e048bc)
https://bugzilla.redhat.com/show_bug.cgi?id=1387708 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ansible Tower Job Template shows the previously selected record when returning from a different view
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1382616