Protect against non-rendering timeline messages #12176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label providers/hawkular, bug |
|
Checked commit jshaughn@4efc39a with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@miq-bot add_label euwe/yes |
|
LGTM 👍 |
simaishi
pushed a commit
that referenced
this pull request
Jan 4, 2017
Protect against non-rendering timeline messages (cherry picked from commit c56ce9e) https://bugzilla.redhat.com/show_bug.cgi?id=1396238
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new timeline widget does not like newlines or double-quotes in the event fields (when you click on the item in the timeline). Some hawkular provider events were hitting this issue. This PR provides protection.
This is likely a timeline widget problem and I will generate issues. But this PR aims to get the hawkular provider events working in the near term.
https://bugzilla.redhat.com/show_bug.cgi?id=1388040