Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Network Topology button for the Load Balancer class #12261

Merged
merged 1 commit into from Oct 31, 2016

Conversation

bronaghs
Copy link

No toolbar button exists for the Load Balancer class in the provider NetworkTopology view. This PR addresses this by adding it.

Before

screenshot-20161021 132733 1

After

screen shot 2016-10-27 at 3 23 21 pm

screen shot 2016-10-27 at 3 23 28 pm

## Links

https://bugzilla.redhat.com/show_bug.cgi?id=1387612

Notes

This fix is not Azure specific despite the BZ description.

@miq-bot
Copy link
Member

miq-bot commented Oct 27, 2016

Checked commit bronaghs@ad27217 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. ⭐

@Ladas
Copy link
Contributor

Ladas commented Oct 31, 2016

looks great to me 👍

@mzazrivec mzazrivec self-assigned this Oct 31, 2016
@mzazrivec mzazrivec added this to the Sprint 49 Ending Nov 14, 2016 milestone Oct 31, 2016
@mzazrivec mzazrivec merged commit 1c98881 into ManageIQ:master Oct 31, 2016
chessbyte pushed a commit that referenced this pull request Nov 1, 2016
Add Network Topology button for the Load Balancer class
(cherry picked from commit 1c98881)

https://bugzilla.redhat.com/show_bug.cgi?id=1387612
@chessbyte
Copy link
Member

Euwe Backport details:

$ git log -1
commit 01fdb31ae4de7b8da800ee52973fe2549eed1015
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Mon Oct 31 15:29:12 2016 +0100

    Merge pull request #12261 from bronaghs/azure_lb_icon_bz1387612

    Add Network Topology button for the Load Balancer class
    (cherry picked from commit 1c98881b2f79730fc4fbe3aa06d6f928c9896fed)

    https://bugzilla.redhat.com/show_bug.cgi?id=1387612

@chessbyte
Copy link
Member

@simaishi Please make Euwe BZ for https://bugzilla.redhat.com/show_bug.cgi?id=1387612

@simaishi
Copy link
Contributor

simaishi commented Nov 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants