Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile update for Service UI repo rename #12263

Merged
merged 1 commit into from Nov 2, 2016
Merged

Dockerfile update for Service UI repo rename #12263

merged 1 commit into from Nov 2, 2016

Conversation

simaishi
Copy link
Contributor

@simaishi simaishi commented Oct 27, 2016 •
edited

- Updated Service UI build steps as per README in manageiq-ui-service repo
(ManageIQ/manageiq-appliance-build#181) Splitting to a separate PR.

@simaishi
Copy link
Contributor Author

@Fryguy please review

@Fryguy
Copy link
Member

Fryguy commented Oct 27, 2016

LGTM 👍

@fbladilo Do you need to mirror these changes into manageiq-pods?

@simaishi
Copy link
Contributor Author

simaishi commented Oct 27, 2016 •
edited

Mirror should happen only after we create 'euwe' branch in manageiq-pods, as this PR includes changes only for master. I should have split to 2 PRs.. sorry.

@Fryguy
Copy link
Member

Fryguy commented Oct 27, 2016

@simaishi Ok...we may want to cut the branch sooner than later, then.

@simaishi simaishi changed the title Dockerfile update for Service UI changes (repo rename and updated steps) Dockerfile update for Service UI repo rename Oct 27, 2016
@simaishi simaishi added euwe/yes and removed euwe/no labels Oct 27, 2016
@simaishi
Copy link
Contributor Author

Splitting this PR to two. This PR now covers just repo rename, so it can be backported to euwe and mirror to manageiq-pods.

@miq-bot
Copy link
Member

miq-bot commented Oct 27, 2016

Checked commit simaishi@da79da2 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
0 files checked, 0 offenses detected
Everything looks good. 🏆

@fbladilo
Copy link
Contributor

@simaishi @Fryguy Certainly need it on manageiq-pods, am I ok to mirror now?

@simaishi
Copy link
Contributor Author

@Fryguy another review please - removed 2 changes that were for 'master' only.

@himdel himdel mentioned this pull request Oct 31, 2016
Closed
simaishi added a commit to simaishi/manageiq-pods that referenced this pull request Nov 1, 2016
@simaishi
Rename SSUI to SUI
daa2bb8 
Related PR: ManageIQ/manageiq#12263
@simaishi simaishi mentioned this pull request Nov 1, 2016
Merged
@chrisarcand chrisarcand assigned chrisarcand and unassigned Fryguy Nov 2, 2016
@chrisarcand chrisarcand merged commit d29e9d0 into ManageIQ:master Nov 2, 2016
@chrisarcand chrisarcand added this to the Sprint 49 Ending Nov 14, 2016 milestone Nov 2, 2016
@simaishi simaishi deleted the docker_sui_update branch November 2, 2016 20:54
@chessbyte
Copy link
Member

According to @simaishi, this does not affect downstream. So, backporting now.

chessbyte pushed a commit that referenced this pull request Nov 7, 2016
@chrisarcand @chessbyte
Merge pull request #12263 from simaishi/docker_sui_update
b97ded6 
Dockerfile update for Service UI repo rename
(cherry picked from commit d29e9d0)
@chessbyte
Copy link
Member

Euwe Backport details:

$ git log -1
commit b97ded6b902f9b911095982835acdd17e115d7af
Author: Chris Arcand <chrisarcand@users.noreply.github.com>
Date:   Wed Nov 2 15:15:04 2016 -0500

    Merge pull request #12263 from simaishi/docker_sui_update

    Dockerfile update for Service UI repo rename
    (cherry picked from commit d29e9d02ed18d48669bde4b812eb123c457f0e0d)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisarcand chrisarcand chrisarcand approved these changes

Assignees

@chrisarcand chrisarcand

Labels
build/docker euwe/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@simaishi @Fryguy @miq-bot @fbladilo @chessbyte @chrisarcand