A proper way of picking available FloatingIP #12300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neither vm and network port has to be associated. There are FloatingIps associated only to NetworkPort, these were offered in provisioning dialog and failed.
|
@miq-bot assign @blomquisg |
|
@blomquisg should be euwe yes, I'll ask for BZ |
|
Checked commit Ladas@5da9967 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@miq-bot remove_tag bugzilla_needed |
|
@blomquisg BZ added |
|
@Ladas unrecognized command 'remove_tag', ignoring... Accepted commands are: add_label, remove_label, rm_label, assign, set_milestone |
|
@miq-bot remove_label bugzilla_needed |
|
@Ladas Cannot remove the following label because they are not recognized: bugzilla_needed |
chessbyte
pushed a commit
that referenced
this pull request
Nov 7, 2016
…floating_ip A proper way of picking available FloatingIP (cherry picked from commit 49d6bdf) https://bugzilla.redhat.com/show_bug.cgi?id=1390203
|
Euwe Backport details: $ git log -1
commit c7ff12bd056f5664537cad2c357a611e4e45a31d
Author: Greg Blomquist <blomquisg@gmail.com>
Date: Wed Nov 2 18:07:34 2016 -0400
Merge pull request #12300 from Ladas/proper_way_of_picking_available_floating_ip
A proper way of picking available FloatingIP
(cherry picked from commit 49d6bdf0fe8bf26dd65f2529df73e89ded2fb5ce)
https://bugzilla.redhat.com/show_bug.cgi?id=1390203 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither vm and network port has to be associated. There are
FloatingIps associated only to NetworkPort, these were offered
in provisioning dialog and failed.
Steps for Testing/QA [Optional]
During provisioning (AWS) only real available FloatingIps should be offered
Fixes BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1390203