Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove filters from container show_list pages #12302

Merged
merged 1 commit into from Nov 3, 2016

Conversation

zeari
Copy link

@zeari zeari commented Oct 31, 2016

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1386473
This removes the filters on containers show_list pages.

cc @simon3z

@zeari zeari changed the title Remove filters Remove filters from container show_list pages Oct 31, 2016
@zeari
Copy link
Author

zeari commented Oct 31, 2016

@miq-bot add_label providers/containers, bug, ui

@miq-bot
Copy link
Member

miq-bot commented Oct 31, 2016

Checked commit zeari@5f6f6c3 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
0 files checked, 0 offenses detected
Everything looks good. 👍

@simon3z
Copy link
Contributor

simon3z commented Nov 1, 2016

LGTM 👍
I had a question on the relevant BZ, but for the record let's please copy/paste the answer here as well: what will happen to old installations? Is this still saved in their DB (and it won't disappear)?.

@simon3z
Copy link
Contributor

simon3z commented Nov 2, 2016

@miq-bot add_label euwe/yes
@miq-bot assign chessbyte

I think this is worth fixing for Euwe (small, contained, and overall good improvement, also it will stop polluting the db of new installations).
@zeari @bazulay we need to handle bureaucracy for the BZ.

@miq-bot miq-bot assigned chessbyte and unassigned simon3z Nov 2, 2016
@zeari
Copy link
Author

zeari commented Nov 3, 2016

what will happen to old installations? Is this still saved in their DB (and it won't disappear)?.

@gtanzillo @blomquisg These fixtures im removing cause some errors. What can I do to remove them in existing(running) installations?

@bazulay
Copy link

bazulay commented Nov 3, 2016

@miq-bot add_label blocker

@miq-bot miq-bot added the blocker label Nov 3, 2016
@chessbyte chessbyte merged commit d77f49c into ManageIQ:master Nov 3, 2016
@chessbyte chessbyte added this to the Sprint 49 Ending Nov 14, 2016 milestone Nov 3, 2016
@zeari
Copy link
Author

zeari commented Nov 7, 2016

@gtanzillo @blomquisg These fixtures im removing cause some errors. What can I do to remove them in existing(running) installations?

ping @gtanzillo @blomquisg

chessbyte added a commit that referenced this pull request Nov 7, 2016
Remove filters from container `show_list` pages
(cherry picked from commit d77f49c)

https://bugzilla.redhat.com/show_bug.cgi?id=1386473
@chessbyte
Copy link
Member

Euwe Backport details:

$ git log -1
commit bf7399b31f956f26c03aae1c0eda63d52ada2c8f
Author: Oleg Barenboim <chessbyte@gmail.com>
Date:   Thu Nov 3 17:40:26 2016 -0400

    Merge pull request #12302 from zeari/remove_filters

    Remove filters from container `show_list` pages
    (cherry picked from commit d77f49cf860eae796645bff42f743c3257ab6188)

    https://bugzilla.redhat.com/show_bug.cgi?id=1386473

@gtanzillo
Copy link
Member

gtanzillo commented Nov 7, 2016

@gtanzillo @blomquisg These fixtures im removing cause some errors. What can I do to remove them in existing(running) installations?

@zeari I think the only 2 options are a data migration (which is not an option) or updating the seed method to handle deletes. Seems like more work that it's worth, though. The other thing you can do is provide a small script the deletes the bad searches to the customer that reported the issue as a one off.

@zeari
Copy link
Author

zeari commented Nov 8, 2016

Thanks @gtanzillo
I think that a script for the specific customer will do the trick here

@zeari zeari deleted the remove_filters branch August 24, 2017 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants