Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags as columns in containerImageChargeback #12305

Closed
wants to merge 1 commit into from

Conversation

zeari
Copy link

@zeari zeari commented Oct 31, 2016

Same as #10940 but for Container images
This adds tags as available fields\columns in Container image chargeback reports

screencapture-localhost-3000-report-explorer-1477932621766

@gtanzillo Please review
cc @simon3z
@miq-bot add_label providers/containers, chargeback

@mikedahlgren
Copy link
Contributor

This is an issue in the field, please consider this for Euwe.

@simon3z
Copy link
Contributor

simon3z commented Nov 1, 2016

@mikedahlgren @zeari do we have a BZ marked for Euwe for this?

@zeari
Copy link
Author

zeari commented Nov 1, 2016

@mikedahlgren @zeari do we have a BZ marked for Euwe for this?

@simon3z I dont think so...

@zeari zeari force-pushed the chargeback_container_image_tags branch 2 times, most recently from 2025385 to 98d13ba Compare November 1, 2016 12:34
@mikedahlgren
Copy link
Contributor

mikedahlgren commented Nov 2, 2016

@zeari @simon3z I was under the impression that this was needed to resolve the bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1354029

Which is under Q/A right now for Euwe.

@simon3z
Copy link
Contributor

simon3z commented Nov 2, 2016

@zeari @simon3z I was under the impression that this was needed to resolve the bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1354029

Which is under Q/A right now for Euwe.

@mikedahlgren no, as the title states it's about Chargeback for Container Images

@zeari zeari force-pushed the chargeback_container_image_tags branch 4 times, most recently from 5cf9a2a to 587610f Compare November 10, 2016 08:41
@miq-bot
Copy link
Member

miq-bot commented Nov 10, 2016

Checked commit zeari@587610f with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
2 files checked, 0 offenses detected
Everything looks good. 🏆

@zeari zeari closed this Nov 15, 2016
@zeari zeari reopened this Nov 15, 2016
@miq-bot
Copy link
Member

miq-bot commented Dec 6, 2016

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

@zeari zeari closed this Dec 7, 2016
@mikedahlgren
Copy link
Contributor

@zeari are you planning on re-opening this or go another path?

@zeari
Copy link
Author

zeari commented Dec 8, 2016

@mikedahlgren This commit was merged in #12851

@zeari zeari deleted the chargeback_container_image_tags branch August 24, 2017 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants